From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933276AbcBYOwI (ORCPT ); Thu, 25 Feb 2016 09:52:08 -0500 Received: from casper.infradead.org ([85.118.1.10]:34598 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933225AbcBYOwF (ORCPT ); Thu, 25 Feb 2016 09:52:05 -0500 Date: Thu, 25 Feb 2016 15:52:02 +0100 From: Peter Zijlstra To: luca abeni Cc: Juri Lelli , linux-kernel@vger.kernel.org Subject: Re: Question about prio_changed_dl() Message-ID: <20160225145202.GQ6356@twins.programming.kicks-ass.net> References: <20160219134345.70ff4aa0@utopia> <20160225140149.GK6357@twins.programming.kicks-ass.net> <20160225152558.2fbac9e5@utopia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160225152558.2fbac9e5@utopia> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 25, 2016 at 03:25:58PM +0100, luca abeni wrote: > > > (BTW, it seems to me that switched_to_dl() is never invoked, for > > > some reason...) > > > > Hmm, it should be invoked if you do sched_setattr() to get > > SCHED_DEADLINE. > > Sorry, that was me being confused... > It is prio_changed_dl() that is not invoked when the deadline > parameters are changed (I am testing a change to fix this - it actually > is included in the "Move the remaining __dl_{sub,add}_ac() calls from > core.c to deadline.c" patch I posted on Monday; I am going to extract > it in a separate patch). Ah ok. So the idea was that the || dl_task() part would ensure ->prio_changed() would always be called. I'll await your patch.