From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933153AbcBYP0z (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Feb 2016 10:26:55 -0500
Received: from mail-yw0-f176.google.com ([209.85.161.176]:35693 "EHLO
	mail-yw0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933117AbcBYP0x (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Feb 2016 10:26:53 -0500
Date: Thu, 25 Feb 2016 12:26:47 -0300
From: Gustavo Padovan <gustavo@padovan.org>
To: Tom Cherry <tomcherry@google.com>
Cc: Greg Hackmann <ghackmann@google.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        John Harrison <John.C.Harrison@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        dri-devel@lists.freedesktop.org, daniels@collabora.com,
        Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Riley Andrews <riandrews@android.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Rob Clark <robdclark@gmail.com>,
        Maarten Lankhorst <maarten.lankhorst@canonical.com>,
        Dmitry Torokhov <dtor@google.com>
Subject: Re: [RFC 26/29] dma-buf/fence: remove pointless
 fence_timeline_signal at destroy phase
Message-ID: <20160225152647.GA2479@joana>
Mail-Followup-To: Gustavo Padovan <gustavo@padovan.org>,
	Tom Cherry <tomcherry@google.com>,
	Greg Hackmann <ghackmann@google.com>,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	John Harrison <John.C.Harrison@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	dri-devel@lists.freedesktop.org, daniels@collabora.com,
	Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
	Riley Andrews <riandrews@android.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Rob Clark <robdclark@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@canonical.com>,
	Dmitry Torokhov <dtor@google.com>
References: <1452869739-3304-1-git-send-email-gustavo@padovan.org>
 <1452869739-3304-27-git-send-email-gustavo@padovan.org>
 <569930FF.1090601@Intel.com>
 <20160115180207.GD2664@joana>
 <569983CC.7000207@google.com>
 <CAPc65azJ_u_ZtEB6hs3=MXr1sGdS5pUzzDV0sQ8f-S0gSzkx7Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAPc65azJ_u_ZtEB6hs3=MXr1sGdS5pUzzDV0sQ8f-S0gSzkx7Q@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2016-02-09 Tom Cherry <tomcherry@google.com>:

> On Fri, Jan 15, 2016 at 3:42 PM, Greg Hackmann <ghackmann@google.com> wrote:
> > On 01/15/2016 10:02 AM, Gustavo Padovan wrote:
> >>
> >> Patches 27 and 28 are attempt to fix that. I assumed that if some code is
> >> calling fence_timeline_destroy() it wants to stop everything so I
> >> worked on a solution that stops any waiter and allows the timeline to be
> >> destroyed.
> >>
> >> No one is using fence_timeline_destroy() in mainline now, so it is
> >> definately a behaviour we can discuss.
> >>
> >>         Gustavo
> >>
> >
> > +Tom Cherry and Dmitry Torokhov recently discovered that this was broken by
> > the refactoring of Android sync on top of dma-buf fences.
> >
> > Tom and Dmitry, did you send the proposed fix upstream?
> 
> There was a similar issue that I had originally thought to be related
> to fence_timeline_destroy() but was actually related to
> sync_fence_free().  Dmitry sent the patch upstream at
> https://lkml.org/lkml/2015/12/14/953, but it does not look like it has
> received any feedback.
> 
> We saw real panics without this patch.  I didn't see this patch or any
> similar changes in the destaging commits, and I would recommend it be
> looked at while destaging this driver.

This patch is already uptream, Greg pushed it in December. :)

	Gustavo