From: Peter Zijlstra <peterz@infradead.org>
To: Alexei Starovoitov <ast@fb.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Wang Nan <wangnan0@huawei.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Brendan Gregg <brendan.d.gregg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] perf: generalize perf_callchain
Date: Thu, 25 Feb 2016 17:45:38 +0100 [thread overview]
Message-ID: <20160225164538.GR6356@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <56CF2DCE.5010501@fb.com>
On Thu, Feb 25, 2016 at 08:37:34AM -0800, Alexei Starovoitov wrote:
> On 2/25/16 6:18 AM, Peter Zijlstra wrote:
> >On Wed, Feb 17, 2016 at 07:58:57PM -0800, Alexei Starovoitov wrote:
> >>. avoid walking the stack when there is no room left in the buffer
> >>. generalize get_perf_callchain() to be called from bpf helper
> >
> >If it does two things it should be two patches.
>
> could have been two patches, but it will only add more churn
> to the same lines. what's the concern?
It makes review easier, shows which modification is for what purpose.
Also the changelog really needs more; it should for example explain what
BPF needs from the callchain code, and preferably why.
next prev parent reply other threads:[~2016-02-25 16:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 3:58 [PATCH net-next 0/3] bpf_get_stackid() and stack_trace map Alexei Starovoitov
2016-02-18 3:58 ` [PATCH net-next 1/3] perf: generalize perf_callchain Alexei Starovoitov
2016-02-25 14:18 ` Peter Zijlstra
2016-02-25 16:37 ` Alexei Starovoitov
2016-02-25 16:45 ` Peter Zijlstra [this message]
2016-02-25 16:48 ` Peter Zijlstra
2016-02-25 16:47 ` Peter Zijlstra
2016-02-25 17:27 ` Alexei Starovoitov
2016-02-18 3:58 ` [PATCH net-next 2/3] bpf: introduce BPF_MAP_TYPE_STACK_TRACE Alexei Starovoitov
2016-02-25 14:23 ` Peter Zijlstra
2016-02-25 16:42 ` Alexei Starovoitov
2016-02-25 16:50 ` Peter Zijlstra
2016-02-18 3:58 ` [PATCH net-next 3/3] samples/bpf: offwaketime example Alexei Starovoitov
2016-02-20 5:25 ` [PATCH net-next 0/3] bpf_get_stackid() and stack_trace map David Miller
2016-02-25 14:24 ` Peter Zijlstra
2016-02-25 16:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225164538.GR6356@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ast@fb.com \
--cc=brendan.d.gregg@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox