From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933556AbcBYTQM (ORCPT ); Thu, 25 Feb 2016 14:16:12 -0500 Received: from mail.kernel.org ([198.145.29.136]:48140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933357AbcBYTQL (ORCPT ); Thu, 25 Feb 2016 14:16:11 -0500 Date: Thu, 25 Feb 2016 16:16:06 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Taeung Song , linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar Subject: Re: [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew() Message-ID: <20160225191606.GR8720@kernel.org> References: <1456413190-12378-1-git-send-email-treeze.taeung@gmail.com> <20160225190222.GB4883@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160225190222.GB4883@krava.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Feb 25, 2016 at 08:02:22PM +0100, Jiri Olsa escreveu: > On Fri, Feb 26, 2016 at 12:13:10AM +0900, Taeung Song wrote: > > script_spec_register() called two functions > > script_spec__find() and script_spec__findnew(). > > But script_spec__find() was called two times. > > > > So remove script_spec__findnew() and make > > script_spec_register() only call once script_spec__find(). > > > > Cc: Jiri Olsa > > Signed-off-by: Taeung Song > > Acked-by: Jiri Olsa Looks good, applied. Thanks, - Arnaldo