From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752021AbcBYVcv (ORCPT ); Thu, 25 Feb 2016 16:32:51 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:32268 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbcBYVcu (ORCPT ); Thu, 25 Feb 2016 16:32:50 -0500 Date: Fri, 26 Feb 2016 00:32:21 +0300 From: Dan Carpenter To: Jassi Brar , Duc Dang Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] mailbox/xgene-slimpro: Checking for IS_ERR instead of NULL Message-ID: <20160225213221.GC18267@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_ioremap() returns NULL, it never returns an ERR_PTR. Fixes: f700e84f417b ('mailbox: Add support for APM X-Gene platform mailbox driver') Signed-off-by: Dan Carpenter diff --git a/drivers/mailbox/mailbox-xgene-slimpro.c b/drivers/mailbox/mailbox-xgene-slimpro.c index b5f5106..bd07f39 100644 --- a/drivers/mailbox/mailbox-xgene-slimpro.c +++ b/drivers/mailbox/mailbox-xgene-slimpro.c @@ -196,8 +196,8 @@ static int slimpro_mbox_probe(struct platform_device *pdev) regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); mb_base = devm_ioremap(&pdev->dev, regs->start, resource_size(regs)); - if (IS_ERR(mb_base)) - return PTR_ERR(mb_base); + if (!mb_base) + return -ENOMEM; /* Setup mailbox links */ for (i = 0; i < MBOX_CNT; i++) {