From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jiri Slaby <jslaby@suse.com>
Cc: linux-kernel@vger.kernel.org
Subject: [report] invalid error code in do_register_con_driver() console
Date: Fri, 26 Feb 2016 00:34:09 +0300 [thread overview]
Message-ID: <20160225213409.GD18267@mwanda> (raw)
Hi Jiri,
I'm getting the following static checker warning:
drivers/tty/vt/vt.c:3588 do_register_con_driver()
warn: missing error code here? 'csw->con_startup()' failed. 'retval' = '0'
drivers/tty/vt/vt.c
3582 if (retval)
3583 goto err;
3584
3585 desc = csw->con_startup();
3586
3587 if (!desc)
3588 goto err;
3589
3590 retval = -EINVAL;
3591
Probably, we could more the "retval = -EINVAL;" before the goto? I
don't think it's intentional?
regards,
dan carpenter
next reply other threads:[~2016-02-25 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 21:34 Dan Carpenter [this message]
2016-05-03 14:26 ` [report] invalid error code in do_register_con_driver() console Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225213409.GD18267@mwanda \
--to=dan.carpenter@oracle.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox