From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752017AbcBYVeU (ORCPT ); Thu, 25 Feb 2016 16:34:20 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:33125 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494AbcBYVeT (ORCPT ); Thu, 25 Feb 2016 16:34:19 -0500 Date: Fri, 26 Feb 2016 00:34:09 +0300 From: Dan Carpenter To: Jiri Slaby Cc: linux-kernel@vger.kernel.org Subject: [report] invalid error code in do_register_con_driver() console Message-ID: <20160225213409.GD18267@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, I'm getting the following static checker warning: drivers/tty/vt/vt.c:3588 do_register_con_driver() warn: missing error code here? 'csw->con_startup()' failed. 'retval' = '0' drivers/tty/vt/vt.c 3582 if (retval) 3583 goto err; 3584 3585 desc = csw->con_startup(); 3586 3587 if (!desc) 3588 goto err; 3589 3590 retval = -EINVAL; 3591 Probably, we could more the "retval = -EINVAL;" before the goto? I don't think it's intentional? regards, dan carpenter