From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751694AbcBYWU5 (ORCPT ); Thu, 25 Feb 2016 17:20:57 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:37171 "EHLO e06smtp14.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbcBYWUz (ORCPT ); Thu, 25 Feb 2016 17:20:55 -0500 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: heiko.carstens@de.ibm.com X-IBM-RcptTo: linux-arch@vger.kernel.org;linux-doc@vger.kernel.org;linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Thu, 25 Feb 2016 23:20:47 +0100 From: Heiko Carstens To: Yury Norov Cc: arnd@arndb.de, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, Prasun.Kapoor@caviumnetworks.com, pinskia@gmail.com, agraf@suse.de, broonie@kernel.org, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com, Nathan_Lynch@mentor.com, klimov.linux@gmail.com, bamvor.zhangjian@huawei.com Subject: Re: [PATCH 3/5] all: s390: move wrapper infrastructure to generic headers Message-ID: <20160225222047.GB5950@osiris> References: <1456338854-14901-1-git-send-email-ynorov@caviumnetworks.com> <1456338854-14901-4-git-send-email-ynorov@caviumnetworks.com> <20160225085140.GC3980@osiris> <20160225202350.GB16123@yury-N73SV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160225202350.GB16123@yury-N73SV> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16022522-0017-0000-0000-00000751C6F6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 25, 2016 at 11:23:50PM +0300, Yury Norov wrote: > On Thu, Feb 25, 2016 at 09:51:40AM +0100, Heiko Carstens wrote: > > On Wed, Feb 24, 2016 at 09:34:12PM +0300, Yury Norov wrote: > > > diff --git a/include/linux/syscalls_structs.h b/include/linux/syscalls_structs.h > > > new file mode 100644 > > > index 0000000..a920cbc > > > --- /dev/null > > > +++ b/include/linux/syscalls_structs.h > > > @@ -0,0 +1,60 @@ > > > +#ifndef _LINUX_SYSCALL_STRUCTS_H > > > +#define _LINUX_SYSCALL_STRUCTS_H > > > + > > > +struct epoll_event; > > > +struct iattr; > > > +struct inode; > > > +struct iocb; > > > +struct io_event; > > > +struct iovec; > > > +struct itimerspec; > > > +struct itimerval; > > > > This is not needed for s390, right? So might be worth a separate patch > > which moves the forward declarations? > > This patch also introduces __SC_WRAP, not needed as well. The idea of > this patch is to introduce all the tricky machinery at once. If you > think we need split it, I'm OK, but maybe it's enough to add more > detailed description... What do you think? Ok, I see. Then the only change I'd like to request is to update the comment in front of the COMPAT_SYSCALL_WRAPx macro which talks about 33/31 bit pointer sizes. This doesn't make too much sense for common code :)