From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752546AbcBZJsi (ORCPT ); Fri, 26 Feb 2016 04:48:38 -0500 Received: from mga14.intel.com ([192.55.52.115]:65313 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbcBZJsg (ORCPT ); Fri, 26 Feb 2016 04:48:36 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="55178892" Date: Fri, 26 Feb 2016 11:48:29 +0200 From: Jarkko Sakkinen To: James Morris Cc: Jerry Snitselaar , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, keyrings@vger.kernel.org, Wilck@intel.com Subject: Re: [tpmdd-devel] [GIT PULL] remaining tpmdd fixes for Linux 4.5 Message-ID: <20160226094829.GA16207@intel.com> References: <20160220081705.GA12981@intel.com> <20160222145023.GA28365@intel.com> <20160225173044.gcr2j65ihv6cevzm@cantor.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2016 at 02:38:52PM +1100, James Morris wrote: > On Thu, 25 Feb 2016, Jerry Snitselaar wrote: > > > On Mon Feb 22 16, Jarkko Sakkinen wrote: > > >On Mon, Feb 22, 2016 at 12:56:53PM +1100, James Morris wrote: > > > > On Sat, 20 Feb 2016, Jarkko Sakkinen wrote: > > > > > > > > > Hi James, > > > > > > > > > > I'm sorry for the late pull request for 4.5. The reason for this was > > > > > the latency in my previous one. I picked with care the absolutely > > > > > critical fixes so that we can make a sound tpmdd release. > > > > > > > > > > I really hope you can still pick these as one of them is absolutely > > > > > critical to get authorization policy sealing API right (kernel keeps > > > > > it finger out of user space created objects). > > > > > > > > Pushed to next for more testing and review. > > > > > > > > This really is getting too late in the development cycle for so many > > > > fixes. It means the code was not ready to be merged in the first place. > > > > > >I fully agree what you're saying. I'll learn the lesson here and take > > >factors more conservative attitude from now on. No excuses. I'm sorry > > >about this. > > > > > >Partly the reason for recent increase in regressions has been > > >increased real-world use of TPM2 and thus issues have started to pop > > >up that's a lame excuse anyway. > > > > > > > Would it be worthwhile to have a tpm branch that gets pulled by -next > > directly so changes will have already been going through the paces in > > -next prior to the pull reuqest to James? > > That would be useful, some other subsystems do that. I'll start using it. > -- > James Morris > /Jarkko