From: Juergen Borleis <jbe@pengutronix.de>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: rtc-linux@googlegroups.com,
Alessandro Zummo <a.zummo@towertech.it>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: pcf85063: remove useless century handling
Date: Fri, 26 Feb 2016 12:07:31 +0100 [thread overview]
Message-ID: <201602261207.31126.jbe@pengutronix.de> (raw)
In-Reply-To: <1456268728-343-1-git-send-email-alexandre.belloni@free-electrons.com>
Hi Alexandre,
On Wednesday 24 February 2016 00:05:28 Alexandre Belloni wrote:
> pcf85063_get_datetime() tries to handle a century bit but that bit is not
> documented and the final value is never used anywhere else in the kernel.
> [...]
> However, I found two interesting things in that driver. I'll send a
> patch shortly, removing the useless century handling.
> Also, I'm quite unsure about the year range handling. I have a patch but
> I'm not sure about the RTC behaviour when the year goes from 99 to 00.
> Can you check that works properly?
Just returned from the embedded world exhibition... Will test it.
Regards,
Juergen
--
Pengutronix e.K. | Juergen Borleis |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2016-02-26 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 23:05 [PATCH] rtc: pcf85063: remove useless century handling Alexandre Belloni
2016-02-26 11:07 ` Juergen Borleis [this message]
2016-03-01 8:29 ` Juergen Borleis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201602261207.31126.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).