From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932901AbcBZLFh (ORCPT ); Fri, 26 Feb 2016 06:05:37 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:46362 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753916AbcBZLFd convert rfc822-to-8bit (ORCPT ); Fri, 26 Feb 2016 06:05:33 -0500 From: Juergen Borleis Organization: Pengutronix e.K. To: Alexandre Belloni Subject: Re: [PATCH] rtc: pcf85063: remove useless century handling Date: Fri, 26 Feb 2016 12:07:31 +0100 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: rtc-linux@googlegroups.com, Alessandro Zummo , linux-kernel@vger.kernel.org References: <1456268728-343-1-git-send-email-alexandre.belloni@free-electrons.com> In-Reply-To: <1456268728-343-1-git-send-email-alexandre.belloni@free-electrons.com> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <201602261207.31126.jbe@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: jbe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, On Wednesday 24 February 2016 00:05:28 Alexandre Belloni wrote: > pcf85063_get_datetime() tries to handle a century bit but that bit is not > documented and the final value is never used anywhere else in the kernel. > [...] > However, I found two interesting things in that driver. I'll send a > patch shortly, removing the useless century handling. > Also, I'm quite unsure about the year range handling. I have a patch but > I'm not sure about the RTC behaviour when the year goes from 99 to 00. > Can you check that works properly? Just returned from the embedded world exhibition... Will test it. Regards, Juergen -- Pengutronix e.K.                              | Juergen Borleis             | Industrial Linux Solutions                    | http://www.pengutronix.de/  |