From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422810AbcBZRmS (ORCPT ); Fri, 26 Feb 2016 12:42:18 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:47654 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754744AbcBZRmQ (ORCPT ); Fri, 26 Feb 2016 12:42:16 -0500 Date: Fri, 26 Feb 2016 09:42:14 -0800 From: Stephen Boyd To: Geert Uytterhoeven Cc: Michael Turquette , Ramesh Shanmugasundaram , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: Ignore disabled DT clock providers Message-ID: <20160226174214.GR28849@codeaurora.org> References: <1456502071-13516-1-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456502071-13516-1-git-send-email-geert+renesas@glider.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26, Geert Uytterhoeven wrote: > of_clk_init() uses for_each_matching_node_and_match() to find clock > providers, which returns all matching device nodes, whether they are > enabled or not. Hence clock providers that are disabled explicitly in DT > using e.g. > > "status = "disabled"; > > are still activated. > > Add a check to ignore device nodes that are not enabled, like > of_irq_init() does. > > Reported-by: Ramesh Shanmugasundaram > Signed-off-by: Geert Uytterhoeven > --- Applied to clk-next Too bad there isn't a for_each_available_matching_node_and_match() macro to make this all one line. It would be a mouthful though. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project