From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755892AbcB0A7A (ORCPT ); Fri, 26 Feb 2016 19:59:00 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:45415 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752617AbcB0A66 (ORCPT ); Fri, 26 Feb 2016 19:58:58 -0500 Date: Fri, 26 Feb 2016 16:58:56 -0800 From: Stephen Boyd To: Andy Shevchenko Cc: Lee Jones , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on error path Message-ID: <20160227005856.GD28849@codeaurora.org> References: <1455871331-93095-1-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455871331-93095-1-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/19, Andy Shevchenko wrote: > There is a potential resource leak in case when ->probe() fails. We have to > unregister and remove clock tree which is done here. > > This is a follow up to previously pushed commit c4726abce63b ("mfd: > intel_quark_i2c_gpio: Use clkdev_create()") that prevents double free() when > clkdev_drop() followed by kfree() in devm_kcalloc() release stage. > > I leave Fixes tag here, but the backporting will require to backport the commit > c4726abce63b ("mfd: intel_quark_i2c_gpio: Use clkdev_create()") first. > > Fixes: 60ae5b9f5cdd (mfd: intel_quark_i2c_gpio: Add Intel Quark X1000 I2C-GPIO MFD Driver) > Cc: stable@vger.kernel.org > Signed-off-by: Andy Shevchenko > --- Both look fine to me. You may also want to use devm_clk_register() instead so that cleanup is easier. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project