Re: [PATCH v7] x86/setup: get ramdisk parameters only once

[Ingo Molnar <mingo@kernel.org>]

* Borislav Petkov <bp@suse.de> wrote:

> >  void __init setup_arch(char **cmdline_p)
> >  {
> > +	struct ramdisk ramdisk = {
> > +		.start_addr = get_ramdisk_image(),
> > +		.size  = PAGE_ALIGN(get_ramdisk_size()),
> > +		.reserve_ramdisk = true
> > +	};
> 
> More readable:
> 
>         struct ramdisk ramdisk = {
>                 .start_addr	 = get_ramdisk_image(),
>                 .size		 = PAGE_ALIGN(get_ramdisk_size()),
>                 .reserve_ramdisk = true,
>         };

So I find it highly annoying that this review feedback was done by Boris, but not 
implemented in v8 :-(

I'd much have preferred fewer iterations and more careful implementation, which 
would have resulted in much less time wasted on the reviewer side...

Anyway, to stop this trainwreck I've fixed this (and a few other small details) 
and applied the patch, but I'd also like to point out that from now on I'll stop 
accepting trivial patches from serial trivial patches contributors that are not 
part of some larger, more substantial work...

Thanks,

	Ingo