From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933965AbcB1DUC (ORCPT ); Sat, 27 Feb 2016 22:20:02 -0500 Received: from mail.kernel.org ([198.145.29.136]:34493 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932421AbcB1DUA (ORCPT ); Sat, 27 Feb 2016 22:20:00 -0500 Date: Sun, 28 Feb 2016 11:19:46 +0800 From: Shawn Guo To: Arnd Bergmann Cc: Sascha Hauer , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: imx: select ARM_CPU_SUSPEND only for imx6 Message-ID: <20160228031946.GF22051@tiger> References: <1456487657-3928107-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456487657-3928107-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2016 at 12:54:12PM +0100, Arnd Bergmann wrote: > i.MX only needs to select ARM_CPU_SUSPEND manually for the > very specific case that CONFIG_PM_SLEEP is disabled and imx6 > is used with CONFIG_PM enabled for runtime PM. > > If we are building a kernel only for CPUs that are not using > the cpu_suspend() helper, we otherwise get a harmless > build warning: > > warning: (ARCH_MXC && SOC_IMX23 && SOC_IMX28 && ARCH_PXA && MACH_MVEBU_V7 && ARCH_OMAP3 && ARCH_OMAP4 && SOC_OMAP5 && SOC_AM33XX && SOC_DRA7XX && ARCH_EXYNOS3 && ARCH_EXYNOS4 && EXYNOS5420_MCPM && EXYNOS_CPU_SUSPEND && ARCH_VEXPRESS_TC2_PM && ARM_BIG_LITTLE_CPUIDLE && ARM_HIGHBANK_CPUIDLE && QCOM_PM) selects ARM_CPU_SUSPEND which has unmet direct dependencies (ARCH_SUSPEND_POSSIBLE) > > This moves the option to the SOC_IMX6 option that actually > requires it, in effect reverting commit f36b594f3754 ("ARM: > mach-imx: Select ARM_CPU_SUSPEND at ARCH_MXC level") that was > meant as a cleanup and unintentionally caused this warning. > > Signed-off-by: Arnd Bergmann Applied, thanks.