public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	live-patching@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
	Peter Zijlstra <peterz@infradead.org>,
	Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
	Namhyung Kim <namhyung@gmail.com>,
	Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
	Chris J Arges <chris.j.arges@canonical.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jiri Slaby <jslaby@suse.cz>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH v18 0/9] Compile-time stack metadata validation
Date: Sun, 28 Feb 2016 07:52:37 +0100	[thread overview]
Message-ID: <20160228065237.GA20796@gmail.com> (raw)
In-Reply-To: <cover.1456440439.git.jpoimboe@redhat.com>


FYI, I got this build failure on allmodconfig-x86-64:

  objtool.c:134:1: error: control reaches end of non-void function [-Werror=return-type]

that was with:

  gcc version 4.8.3 20140911 (Red Hat 4.8.3-7) (GCC) 

GCC 5.2.1 does not trigger this warning, which is I suspect why you have not seen 
this in your own testing.

I applied the fix below: all paths that generate a nonzero error do an explicit 
exit(), so return 0 is fine here.

Thanks,

	Ingo

=====================>

 tools/objtool/objtool.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/objtool/objtool.c b/tools/objtool/objtool.c
index 4e53d272c0c3..46c326db4f46 100644
--- a/tools/objtool/objtool.c
+++ b/tools/objtool/objtool.c
@@ -131,4 +131,6 @@ int main(int argc, const char **argv)
 		cmd_usage();
 
 	handle_internal_command(argc, argv);
+
+	return 0;
 }

  parent reply	other threads:[~2016-02-28  6:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 22:57 [PATCH v18 0/9] Compile-time stack metadata validation Josh Poimboeuf
2016-02-25 22:57 ` [PATCH v18 1/9] objtool: Mark non-standard files and directories Josh Poimboeuf
2016-02-25 22:57 ` [PATCH v18 2/9] objtool: Add STACK_FRAME_NON_STANDARD macro Josh Poimboeuf
2016-02-25 22:57 ` [PATCH v18 3/9] x86/xen: Mark xen_cpuid() stack frame as non-standard Josh Poimboeuf
2016-02-25 22:57 ` [PATCH v18 4/9] bpf: Mark __bpf_prog_run() " Josh Poimboeuf
2016-02-25 22:57 ` [PATCH v18 5/9] sched: Mark __schedule() " Josh Poimboeuf
2016-02-25 22:57 ` [PATCH v18 6/9] x86/kprobes: Mark kretprobe_trampoline() " Josh Poimboeuf
2016-02-25 22:57 ` [PATCH v18 7/9] objtool: Compile-time stack metadata validation Josh Poimboeuf
2016-02-25 22:57 ` [PATCH v18 8/9] objtool: Add CONFIG_STACK_VALIDATION option Josh Poimboeuf
2016-02-25 22:57 ` [PATCH v18 9/9] objtool: Enable stack metadata validation on x86_64 Josh Poimboeuf
2016-02-28  6:52 ` Ingo Molnar [this message]
2016-02-28  6:57 ` [PATCH v18 0/9] Compile-time stack metadata validation Ingo Molnar
2016-02-28 17:00   ` Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160228065237.GA20796@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=bernd@petrovitsch.priv.at \
    --cc=bp@alien8.de \
    --cc=chris.j.arges@canonical.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@redhat.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mmarek@suse.cz \
    --cc=namhyung@gmail.com \
    --cc=palves@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox