From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756878AbcB1Gwo (ORCPT ); Sun, 28 Feb 2016 01:52:44 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36241 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751134AbcB1Gwn (ORCPT ); Sun, 28 Feb 2016 01:52:43 -0500 Date: Sun, 28 Feb 2016 07:52:37 +0100 From: Ingo Molnar To: Josh Poimboeuf Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Michal Marek , Peter Zijlstra , Andy Lutomirski , Borislav Petkov , Linus Torvalds , Andi Kleen , Pedro Alves , Namhyung Kim , Bernd Petrovitsch , Chris J Arges , Andrew Morton , Jiri Slaby , Arnaldo Carvalho de Melo Subject: Re: [PATCH v18 0/9] Compile-time stack metadata validation Message-ID: <20160228065237.GA20796@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org FYI, I got this build failure on allmodconfig-x86-64: objtool.c:134:1: error: control reaches end of non-void function [-Werror=return-type] that was with: gcc version 4.8.3 20140911 (Red Hat 4.8.3-7) (GCC) GCC 5.2.1 does not trigger this warning, which is I suspect why you have not seen this in your own testing. I applied the fix below: all paths that generate a nonzero error do an explicit exit(), so return 0 is fine here. Thanks, Ingo =====================> tools/objtool/objtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/objtool/objtool.c b/tools/objtool/objtool.c index 4e53d272c0c3..46c326db4f46 100644 --- a/tools/objtool/objtool.c +++ b/tools/objtool/objtool.c @@ -131,4 +131,6 @@ int main(int argc, const char **argv) cmd_usage(); handle_internal_command(argc, argv); + + return 0; }