From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758678AbcB1QTV (ORCPT ); Sun, 28 Feb 2016 11:19:21 -0500 Received: from mail-lb0-f194.google.com ([209.85.217.194]:33952 "EHLO mail-lb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758200AbcB1QTT (ORCPT ); Sun, 28 Feb 2016 11:19:19 -0500 Date: Sun, 28 Feb 2016 17:19:24 +0100 From: Johan Hovold To: Konstantin Shkolnyy Cc: johan@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/3 RESEND] USB: serial: cp210x: New 16-bit register access functions. Message-ID: <20160228161924.GG32461@localhost> References: <1456581316-25388-1-git-send-email-konstantin.shkolnyy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456581316-25388-1-git-send-email-konstantin.shkolnyy@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 27, 2016 at 07:55:16AM -0600, Konstantin Shkolnyy wrote: > cp210x_get_config and cp210x_set_config are cumbersome to use. This change > introduces new register access functions for 16-bit values, instead of > the above functions. > > Signed-off-by: Konstantin Shkolnyy > --- > change in v4: Instead of adding all new functions a one separate patch, added > them with patches that actually start using them. Also amended the cp210x_open > change as directed by Johan Hovold. > > change in v3: Presented new function addition as a separate patch #1, > to simplify code review. For some reason these patches fail to apply. What tree did you generate them against? Care to respin against usb-next of git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git [ Note that there really hasn't been any changes to the driver since you added tx_empty back in November. ] Thanks, Johan