From: Mark Brown <broonie@kernel.org>
To: Maarten ter Huurne <maarten@treewalker.org>
Cc: Wenyou Yang <wenyou.yang@atmel.com>,
Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] regulator: act8865: Pass of_node via act8865_regulator_data
Date: Mon, 29 Feb 2016 20:37:05 +0900 [thread overview]
Message-ID: <20160229113705.GA18327@sirena.org.uk> (raw)
In-Reply-To: <1456674809-16422-5-git-send-email-maarten@treewalker.org>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Sun, Feb 28, 2016 at 04:53:27PM +0100, Maarten ter Huurne wrote:
> + struct regulator_config config = {
> + .dev = dev,
> + .regmap = act8865->regmap,
> + .driver_data = act8865,
> + };
> + struct act8865_regulator_data *rdata;
> struct regulator_dev *rdev;
>
> - config.dev = dev;
> - config.init_data = act8865_get_init_data(desc->id, pdata);
> - config.of_node = of_node[i];
> - config.driver_data = act8865;
> - config.regmap = act8865->regmap;
This appears to be doing some unrelated refectoring of the code which
should be in a separate commit to make review clearer.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-29 11:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-28 15:53 [PATCH 1/7] regulator: act8865: Expose act8600 registers via debugfs Maarten ter Huurne
2016-02-28 15:53 ` [PATCH 2/7] regulator: act8865: Remove redundant dev lookups Maarten ter Huurne
2016-02-28 15:53 ` [PATCH 3/7] regulator: act8865: Remove "static" from local variable Maarten ter Huurne
2016-02-28 15:53 ` [PATCH 4/7] regulator: act8865: Rename platform_data field to init_data Maarten ter Huurne
2016-02-28 15:53 ` [PATCH 5/7] regulator: act8865: Pass of_node via act8865_regulator_data Maarten ter Huurne
2016-02-29 11:37 ` Mark Brown [this message]
2016-02-28 15:53 ` [PATCH 6/7] regulator: act8865: Specify fixed voltage of 3.3V for ACT8600's REG9 Maarten ter Huurne
2016-02-28 15:53 ` [PATCH 7/7] regulator: act8865: Init at subsys level Maarten ter Huurne
2016-02-29 11:35 ` Mark Brown
2016-03-17 14:17 ` Maarten ter Huurne
2016-02-29 11:28 ` [PATCH 1/7] regulator: act8865: Expose act8600 registers via debugfs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229113705.GA18327@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten@treewalker.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox