From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754478AbcB2NAA (ORCPT ); Mon, 29 Feb 2016 08:00:00 -0500 Received: from mga04.intel.com ([192.55.52.120]:58970 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754372AbcB2M75 (ORCPT ); Mon, 29 Feb 2016 07:59:57 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,520,1449561600"; d="scan'208";a="926158531" Date: Mon, 29 Feb 2016 14:59:48 +0200 From: Mika Westerberg To: Heikki Krogerus Cc: "Rafael J. Wysocki" , Lee Jones , Andy Shevchenko , Thierry Reding , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH] device property: don't bother the drivers with struct property_set Message-ID: <20160229125948.GA1794@lahna.fi.intel.com> References: <1456485600-129229-1-git-send-email-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456485600-129229-1-git-send-email-heikki.krogerus@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2016 at 01:20:00PM +0200, Heikki Krogerus wrote: > Since device_add_property_set() now always takes a copy of > the property_set, and also since the fwnode type is always > hard coded to be FWNODE_PDATA, there is no need for the > drivers to deliver the entire struct property_set. The > function can just create the instance of it on its own and > bind the properties from the drivers to it on the spot. > > This renames device_add_property_set() to > device_add_properties(). The function now takes struct > property_entry as its parameter instead of struct > property_set. > > Signed-off-by: Heikki Krogerus Nice! Reviewed-by: Mika Westerberg