From: Andi Kleen <andi@firstfloor.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>,
jolsa@kernel.org, namhyung@kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
alexander.shishkin@intel.com, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/2] perf, tools, script: Add support for printing assembler
Date: Mon, 29 Feb 2016 18:35:28 +0100 [thread overview]
Message-ID: <20160229173528.GP5083@two.firstfloor.org> (raw)
In-Reply-To: <20160229145625.GB32719@kernel.org>
> What kernel have you used for testing this? 4.5-rc? I'm having trouble
> with intel_pt with 4.5.0-rc4 :-\
Works for me (on -rc5). What problem do you see?
>
> And while this looks like a great feature to have, have you considered
> using what is in tools/perf/util/intel-pt-decoder/ somehow, so that we
> don't end up adding one more dependency on another external library?
This needs a text disassembler.
The PT decoder doesn't have a disassembler unfortunately. The kernel
instruction decoder is also not a text disassembler. Changing it to do
that would be a quite large project.
> It would be great if we could, if done that way, perhaps at some point
> we could stop using objdump somehow :-\
objdump does a lot of work to line up the source code correctly.
Reproducing it would be a lot of work in perf too, and need
large scales changes. Perhaps at some time, but not any time
soon.
-Andi
next prev parent reply other threads:[~2016-02-29 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 0:32 [PATCH 1/2] perf, tools: Add support for skipping itrace instructions Andi Kleen
2016-02-27 0:32 ` [PATCH 2/2] perf, tools, script: Add support for printing assembler Andi Kleen
2016-02-29 10:27 ` Jiri Olsa
2016-02-29 14:56 ` Arnaldo Carvalho de Melo
2016-02-29 17:35 ` Andi Kleen [this message]
2016-02-29 19:25 ` Arnaldo Carvalho de Melo
2016-03-01 15:35 ` Intel PT not work on 4.5-rc6 as well after suspend/resume assembler Arnaldo Carvalho de Melo
2016-03-01 23:49 ` Andi Kleen
2016-03-02 12:02 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229173528.GP5083@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox