From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753066AbcB2Rfe (ORCPT ); Mon, 29 Feb 2016 12:35:34 -0500 Received: from one.firstfloor.org ([193.170.194.197]:52953 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751261AbcB2Rfc (ORCPT ); Mon, 29 Feb 2016 12:35:32 -0500 Date: Mon, 29 Feb 2016 18:35:28 +0100 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Andi Kleen , jolsa@kernel.org, namhyung@kernel.org, Adrian Hunter , alexander.shishkin@intel.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 2/2] perf, tools, script: Add support for printing assembler Message-ID: <20160229173528.GP5083@two.firstfloor.org> References: <1456533128-28381-1-git-send-email-andi@firstfloor.org> <1456533128-28381-2-git-send-email-andi@firstfloor.org> <20160229145625.GB32719@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160229145625.GB32719@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > What kernel have you used for testing this? 4.5-rc? I'm having trouble > with intel_pt with 4.5.0-rc4 :-\ Works for me (on -rc5). What problem do you see? > > And while this looks like a great feature to have, have you considered > using what is in tools/perf/util/intel-pt-decoder/ somehow, so that we > don't end up adding one more dependency on another external library? This needs a text disassembler. The PT decoder doesn't have a disassembler unfortunately. The kernel instruction decoder is also not a text disassembler. Changing it to do that would be a quite large project. > It would be great if we could, if done that way, perhaps at some point > we could stop using objdump somehow :-\ objdump does a lot of work to line up the source code correctly. Reproducing it would be a lot of work in perf too, and need large scales changes. Perhaps at some time, but not any time soon. -Andi