From: Brian Starkey <brian.starkey@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Dan Williams <dan.j.williams@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/4] drivers: dma-coherent: use memset_io for DMA_MEMORY_IO mappings
Date: Tue, 1 Mar 2016 09:03:22 +0000 [thread overview]
Message-ID: <20160301090322.GA6013@e106950-lin.cambridge.arm.com> (raw)
In-Reply-To: <20160229151749.a972ae993adffb667140548d@linux-foundation.org>
Hi Andrew,
On Mon, Feb 29, 2016 at 03:17:49PM -0800, Andrew Morton wrote:
>On Mon, 29 Feb 2016 16:09:24 +0000 Brian Starkey <brian.starkey@arm.com> wrote:
>
>> Use memset_io() for DMA_MEMORY_IO mappings which are mapped as I/O
>> memory, and regular memset() for DMA_MEMORY_MAP mappings.
>>
>> This fixes the below alignment fault on arm64 for DMA_MEMORY_IO
>> mappings, where memset() uses the DC ZVA instruction which is
>> invalid on device memory.
>
>What's the urgency of this fix? "Hair on fire needed in stable asap"
>or "Nice to have in there for 4.6" or what?
>
No-one else is complaining so probably not the former. If it could
make 4.6 though that would be grand.
As for stable, anything before 3.15 doesn't hit the fault (on arm64)
because memset() is different, so probably not needed there.
For anything after that this patch in isolation isn't a full fix,
because dma_init_coherent_memory() will still use the wrong mapping
function for DMA_MEMORY_MAP. In that case, I think it needs to be the
whole series or nothing. I don't have a strong opinion either way, but
perhaps someone else does.
Thanks
Brian
prev parent reply other threads:[~2016-03-01 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 16:09 [PATCH v2 0/4] Fix kernel panic in dma-coherent allocations Brian Starkey
2016-02-29 16:09 ` [PATCH v2 1/4] memremap: don't modify flags Brian Starkey
2016-02-29 16:09 ` [PATCH v2 2/4] memremap: add MEMREMAP_WC flag Brian Starkey
2016-02-29 16:09 ` [PATCH v2 3/4] drivers: dma-coherent: use MEMREMAP_WC for DMA_MEMORY_MAP Brian Starkey
2016-02-29 16:09 ` [PATCH v2 4/4] drivers: dma-coherent: use memset_io for DMA_MEMORY_IO mappings Brian Starkey
2016-02-29 23:17 ` Andrew Morton
2016-03-01 9:03 ` Brian Starkey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301090322.GA6013@e106950-lin.cambridge.arm.com \
--to=brian.starkey@arm.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).