From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754011AbcCAN6o (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Mar 2016 08:58:44 -0500
Received: from mail.skyhub.de ([78.46.96.112]:47093 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753859AbcCAN6n (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Mar 2016 08:58:43 -0500
Date: Tue, 1 Mar 2016 14:58:39 +0100
From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>, Huang Rui <ray.huang@amd.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Robert Richter <rric@kernel.org>, Jacob Shin <jacob.w.shin@gmail.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Kan Liang <kan.liang@intel.com>, linux-kernel@vger.kernel.org,
        spg_linux_kernel@amd.com, x86@kernel.org,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
        Fengguang Wu <fengguang.wu@intel.com>,
        Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v5] perf/x86/amd/power: Add AMD accumulated power
 reporting mechanism
Message-ID: <20160301135838.GA22677@pd.tnic>
References: <1456479650-4942-1-git-send-email-ray.huang@amd.com>
 <alpine.DEB.2.11.1602261100570.3638@nanos>
 <20160229180048.GB20610@hr-amur2>
 <alpine.DEB.2.11.1602291125510.3638@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.11.1602291125510.3638@nanos>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 29, 2016 at 12:30:47PM +0100, Thomas Gleixner wrote:
> On Tue, 1 Mar 2016, Huang Rui wrote:
> > On Fri, Feb 26, 2016 at 11:18:28AM +0100, Thomas Gleixner wrote:
> > > > +static int __init amd_power_pmu_init(void)
> > > > +{
> > > > +	int i, ret;
> > > > +	u64 tmp;
> > > > +
> > > > +	if (!x86_match_cpu(cpu_match))
> > > > +		return 0;
> > > > +
> > > > +	if (!boot_cpu_has(X86_FEATURE_ACC_POWER))
> > > > +		return -ENODEV;
> > > > +
> > > > +	cores_per_cu = amd_get_cores_per_cu();
> > > > +	cu_num = boot_cpu_data.x86_max_cores / cores_per_cu;
> > > 
> > > Please use the new package management functions which are on the way to tip.
> > > 
> > Can you give me some hints?
> 
> http://git.kernel.org/tip/1f12e32f4cd5243ae46d8b933181be0d022c6793
> 
> topology_max_packages() is what you want.

Rui, I think you want to use smp_num_siblings here. And we did define
that amd_get_cores_per_cu() but that's redundant:

                /* get compute unit information */
                smp_num_siblings = ((ebx >> 8) & 3) + 1;
                c->compute_unit_id = ebx & 0xff;
                cores_per_cu += ((ebx >> 8) & 3);

So if I'm not missing anything else, we don't need that cores_per_cu
variable, nor do we need amd_get_cores_per_cu(). I'll zap this patch
from my queue. You can use smp_num_siblings in your patch instead which
is exported to everything.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.