From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754404AbcCAO4G (ORCPT ); Tue, 1 Mar 2016 09:56:06 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:35500 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753513AbcCAO4D (ORCPT ); Tue, 1 Mar 2016 09:56:03 -0500 Date: Tue, 1 Mar 2016 15:55:58 +0100 From: Thierry Reding To: Sudip Mukherjee Cc: Alessandro Zummo , Alexandre Belloni , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [PATCH] rtc: rtc-vr41xx: remove unused function Message-ID: <20160301145558.GC26201@ulmo> References: <1456836981-30999-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uXxzq0nDebZQVNAZ" Content-Disposition: inline In-Reply-To: <1456836981-30999-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uXxzq0nDebZQVNAZ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 01, 2016 at 06:26:21PM +0530, Sudip Mukherjee wrote: > We were getting build warning about: > drivers/rtc/rtc-vr41xx.c:228:12: warning: =E2=80=98vr41xx_rtc_alarm_irq_e= nable=E2=80=99 > defined but not used >=20 > The function vr41xx_rtc_alarm_irq_enable() was not used anywhere. >=20 > Signed-off-by: Sudip Mukherjee > --- >=20 > build log is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/112780206 >=20 > drivers/rtc/rtc-vr41xx.c | 18 ------------------ > 1 file changed, 18 deletions(-) >=20 > diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c > index f64c282..68cb63e 100644 > --- a/drivers/rtc/rtc-vr41xx.c > +++ b/drivers/rtc/rtc-vr41xx.c > @@ -225,24 +225,6 @@ static int vr41xx_rtc_ioctl(struct device *dev, unsi= gned int cmd, unsigned long > return 0; > } > =20 > -static int vr41xx_rtc_alarm_irq_enable(struct device *dev, unsigned int = enabled) > -{ > - spin_lock_irq(&rtc_lock); > - if (enabled) { > - if (!alarm_enabled) { > - enable_irq(aie_irq); > - alarm_enabled =3D 1; > - } > - } else { > - if (alarm_enabled) { > - disable_irq(aie_irq); > - alarm_enabled =3D 0; > - } > - } > - spin_unlock_irq(&rtc_lock); > - return 0; > -} > - I don't think it's supposed to be unused, rather back at the time it simply wasn't hooked up to the rtc_class_ops. Here's what I used. Thierry --- >8 --- =46rom 91c39e61b10551f8fbdb55cadbc29a104071bea2 Mon Sep 17 00:00:00 2001 =46rom: Thierry Reding Date: Tue, 1 Mar 2016 15:50:25 +0100 Subject: [PATCH] rtc: vr41xx: Hook up ->alarm_irq_enable() The vr41xx_rtc_alarm_irq_enable() function was extracted in commit 16380c153a69 ("RTC: Convert rtc drivers to use the alarm_irq_enable method") from a more generic IOCTL handler. However the function was never hooked up to the struct rtc_class_ops to which a new callback had earlier been added for this purpose in commit 099e657625e8 ("rtc: add alarm/update irq interfaces"). Signed-off-by: Thierry Reding --- drivers/rtc/rtc-vr41xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c index f64c282275b3..898fdd03668d 100644 --- a/drivers/rtc/rtc-vr41xx.c +++ b/drivers/rtc/rtc-vr41xx.c @@ -278,6 +278,7 @@ static const struct rtc_class_ops vr41xx_rtc_ops =3D { .set_time =3D vr41xx_rtc_set_time, .read_alarm =3D vr41xx_rtc_read_alarm, .set_alarm =3D vr41xx_rtc_set_alarm, + .alarm_irq_enable =3D vr41xx_rtc_alarm_irq_enable, }; =20 static int rtc_probe(struct platform_device *pdev) --=20 2.7.1 --uXxzq0nDebZQVNAZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJW1a18AAoJEN0jrNd/PrOhXO4QAIPejJxvD5R+txLKVt4q05JJ A0xRGJM/Wt6yDozdMhbfYXiRy4Fuv79rIdxX4x+llL6HPCVsYAEn34IYFiquUGfA MTkc6145yh7A3TkVEni0l+NR0py3eDlUFpExqlsXiNmj2rG8XZPl3EYM0FZABrN0 MizRdsfJOYeHx1fdP6rPCAbcUrZNr1gqbLhvMQljbVeAY9fCUou1ZNwa8j7mT2BW XAgh6gyDaTEDhbsFlPQfwTnW/UJUNUALiGDUPJ+PH/C9OhaX4e0cM1IPK4IKmHQt Ln2NnNgfTc1m/waSgnF3VejKRoDZbBVJ/t953RQWeYk6eTsKzwifA6Gqz7Vnapf3 QGUAS65q9i5UBIRkf6AL/E2NTyhqP6+qwKOa9jOFNKvE/Ss6TsBZs9e0g1gjgblu mB7nl4R5ThqZdrYQu69r0RVaPWObKEgC4Zj8ZOCOoc12b5PlE4EfRxFfQ5501VPa pL2ukp6ts1waJSzfm/ajFJtvnrTYm+9Tg96lAwoZt36++mSTb/JiPfxjk0jTO14H VgSv0iFlvcsKGtfy79Yrmp0Wa2PRZhG9uRPRQ8Scl7ss5duMdBNVQfSfpK4r60V3 J69U1o0P63qKbkaE3+4O4g1O2pHnv9UDJc2AFz55GelwfxaTfgqDgNkQUyfIe8Jz /6Zpq/WB+leEt3tKKiCp =KVKk -----END PGP SIGNATURE----- --uXxzq0nDebZQVNAZ--