From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752492AbcCASuA (ORCPT ); Tue, 1 Mar 2016 13:50:00 -0500 Received: from mail-yw0-f172.google.com ([209.85.161.172]:34216 "EHLO mail-yw0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbcCASt4 (ORCPT ); Tue, 1 Mar 2016 13:49:56 -0500 Date: Tue, 1 Mar 2016 13:49:49 -0500 From: Tejun Heo To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Andrew Morton , rjw@rjwysocki.net, konrad.wilk@oracle.com, Ingo Molnar , paulmck@linux.vnet.ibm.com, davem@davemloft.net, linux-acpi@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC][PATCH] tags: Fix DEFINE_PER_CPU expansions Message-ID: <20160301184949.GJ3965@htj.duckdns.org> References: <20160301102625.GQ6357@twins.programming.kicks-ass.net> <20160301163707.GF3965@htj.duckdns.org> <20160301181842.GX6357@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160301181842.GX6357@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, Mar 01, 2016 at 07:18:42PM +0100, Peter Zijlstra wrote: > > Urgh... I really hate the fact that we're putting on arbitrary > > formatting constraints to compensate for shortcomings in an > > out-of-line utility. > > Yes it does. > > I'm not too bothered if you don't want to fix this, I just figured I'd > have a stab at fixing all this, since I regularly run 'make tags' and > got tired of seeing the warns. I use cscope so haven't noticed them. > > Can't it do multiline regex? > > Apparently not: > > https://sourceforge.net/p/ctags/feature-requests/38/ That's unfortunate. Ah well, it's only several spots and isn't a big deal one way or the other. Occasional >80 lines are fine by me. Please feel free to add Acked-by: Tejun Heo Thanks. -- tejun