From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753078AbcCAVe7 (ORCPT ); Tue, 1 Mar 2016 16:34:59 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:37252 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752485AbcCAVe5 (ORCPT ); Tue, 1 Mar 2016 16:34:57 -0500 Date: Tue, 1 Mar 2016 22:34:44 +0100 From: Peter Zijlstra To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, Andrew Morton , rjw@rjwysocki.net, konrad.wilk@oracle.com, Ingo Molnar , tj@kernel.org, davem@davemloft.net, linux-acpi@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC][PATCH] tags: Fix DEFINE_PER_CPU expansions Message-ID: <20160301213444.GZ6357@twins.programming.kicks-ass.net> References: <20160301102625.GQ6357@twins.programming.kicks-ass.net> <20160301165650.GN3577@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160301165650.GN3577@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 01, 2016 at 08:56:50AM -0800, Paul E. McKenney wrote: > +++ b/kernel/rcu/rcutorture.c > @@ -131,9 +131,9 @@ static unsigned long rcu_torture_current_version; > static struct rcu_torture rcu_tortures[10 * RCU_TORTURE_PIPE_LEN]; > static DEFINE_SPINLOCK(rcu_torture_lock); > static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1], > - rcu_torture_count) = { 0 }; > + rcu_torture_count); So the problem I was fixing is that the ctags regex needs the second argument for the DEFINE_PER_CPU() macro on the same line. So it would still need to be: static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1], rcu_torture_count); > static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1], > - rcu_torture_batch) = { 0 }; > + rcu_torture_batch); > static atomic_t rcu_torture_wcount[RCU_TORTURE_PIPE_LEN + 1]; > static atomic_t n_rcu_torture_alloc; > static atomic_t n_rcu_torture_alloc_fail; >