* [PATCH] batman-adv: clarify CFG80211 dependency
@ 2016-03-02 13:54 Arnd Bergmann
2016-03-02 14:46 ` Antonio Quartulli
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2016-03-02 13:54 UTC (permalink / raw)
To: Antonio Quartulli
Cc: linux-arm-kernel, Arnd Bergmann, Marek Lindner, Simon Wunderlich,
David S. Miller, b.a.t.m.a.n, netdev, linux-kernel
The driver calls cfg80211_get_station, which may be part of a
module, so we must not enable BATMAN_ADV_BATMAN_V if
BATMAN_ADV=y and CFG80211=m:
net/built-in.o: In function `batadv_v_elp_get_throughput':
(text+0x5c62c): undefined reference to `cfg80211_get_station'
This clarifies the dependency to cover all combinations.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: c833484e5f38 ("batman-adv: ELP - compute the metric based on the estimated throughput")
---
net/batman-adv/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig
index e651dc927bfd..f66930ee3c0b 100644
--- a/net/batman-adv/Kconfig
+++ b/net/batman-adv/Kconfig
@@ -17,7 +17,7 @@ config BATMAN_ADV
config BATMAN_ADV_BATMAN_V
bool "B.A.T.M.A.N. V protocol (experimental)"
- depends on BATMAN_ADV && CFG80211
+ depends on BATMAN_ADV && CFG80211=y || (CFG80211=m && BATMAN_ADV=m)
default n
help
This option enables the B.A.T.M.A.N. V protocol, the successor
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] batman-adv: clarify CFG80211 dependency
2016-03-02 13:54 [PATCH] batman-adv: clarify CFG80211 dependency Arnd Bergmann
@ 2016-03-02 14:46 ` Antonio Quartulli
2016-03-02 18:46 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Antonio Quartulli @ 2016-03-02 14:46 UTC (permalink / raw)
To: Arnd Bergmann, David S. Miller
Cc: linux-arm-kernel, Marek Lindner, Simon Wunderlich, b.a.t.m.a.n,
netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Wed, Mar 02, 2016 at 02:54:35PM +0100, Arnd Bergmann wrote:
> The driver calls cfg80211_get_station, which may be part of a
> module, so we must not enable BATMAN_ADV_BATMAN_V if
> BATMAN_ADV=y and CFG80211=m:
>
> net/built-in.o: In function `batadv_v_elp_get_throughput':
> (text+0x5c62c): undefined reference to `cfg80211_get_station'
>
> This clarifies the dependency to cover all combinations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c833484e5f38 ("batman-adv: ELP - compute the metric based on the estimated throughput")
Acked-by: Antonio Quartulli <a@unstable.cc>
Thanks a lot Arnd!
David, could you please merge this change in net-next directly ?
Regards,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] batman-adv: clarify CFG80211 dependency
2016-03-02 14:46 ` Antonio Quartulli
@ 2016-03-02 18:46 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2016-03-02 18:46 UTC (permalink / raw)
To: a
Cc: arnd, linux-arm-kernel, mareklindner, sw, b.a.t.m.a.n, netdev,
linux-kernel
From: Antonio Quartulli <a@unstable.cc>
Date: Wed, 2 Mar 2016 22:46:07 +0800
> On Wed, Mar 02, 2016 at 02:54:35PM +0100, Arnd Bergmann wrote:
>> The driver calls cfg80211_get_station, which may be part of a
>> module, so we must not enable BATMAN_ADV_BATMAN_V if
>> BATMAN_ADV=y and CFG80211=m:
>>
>> net/built-in.o: In function `batadv_v_elp_get_throughput':
>> (text+0x5c62c): undefined reference to `cfg80211_get_station'
>>
>> This clarifies the dependency to cover all combinations.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: c833484e5f38 ("batman-adv: ELP - compute the metric based on the estimated throughput")
>
> Acked-by: Antonio Quartulli <a@unstable.cc>
>
> Thanks a lot Arnd!
>
> David, could you please merge this change in net-next directly ?
Done, applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-02 18:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-02 13:54 [PATCH] batman-adv: clarify CFG80211 dependency Arnd Bergmann
2016-03-02 14:46 ` Antonio Quartulli
2016-03-02 18:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).