From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757198AbcCBC17 (ORCPT ); Tue, 1 Mar 2016 21:27:59 -0500 Received: from mail-bl2on0097.outbound.protection.outlook.com ([65.55.169.97]:59456 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757079AbcCBC1z (ORCPT ); Tue, 1 Mar 2016 21:27:55 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O3E46B-08-7FA-02 X-M-MSG: Date: Wed, 2 Mar 2016 10:26:53 +0800 From: Huang Rui To: Borislav Petkov , Thomas Gleixner CC: Peter Zijlstra , Ingo Molnar , Andy Lutomirski , Robert Richter , Jacob Shin , Arnaldo Carvalho de Melo , Kan Liang , , , , Suravee Suthikulpanit , Aravind Gopalakrishnan , Fengguang Wu , Guenter Roeck Subject: Re: [PATCH v5] perf/x86/amd/power: Add AMD accumulated power reporting mechanism Message-ID: <20160302022652.GB26547@hr-amur2> References: <1456479650-4942-1-git-send-email-ray.huang@amd.com> <20160229180048.GB20610@hr-amur2> <20160301135838.GA22677@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160301135838.GA22677@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(189002)(24454002)(199003)(164054003)(57704003)(15975445007)(101416001)(5008740100001)(189998001)(97756001)(11100500001)(54356999)(105586002)(83506001)(575784001)(77096005)(87936001)(50986999)(5001770100001)(106466001)(19580395003)(86362001)(4001350100001)(33716001)(1076002)(92566002)(46406003)(1220700001)(93886004)(586003)(76176999)(2950100001)(1720100001)(23726003)(2906002)(50466002)(1096002)(33656002)(4326007)(47776003)(5001960100004)(81156009)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0705;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 152b0e21-432c-44bf-ad01-08d34242411a X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0705;2:GkO9MKTz5YrIcxcepMkXM8EZGFlnE3D0GbjdZO9QJq4K6GgkiPMHBAp6DtVuw5LWDPDv9MH9ISxpjdjk7fQRmC4y6Jg9FQ9Mw6HdR1CdpAK4+S0I56Cs2+bRjGYZHl3qP+Hakji6A7H/ZEJfaE5Xp33KcWLNUxG7sgcpQ7PXPnBEuvlqDQYcpPTRIC+DSbJG;3:GMwTZGNaE/DVcjrO93Y1dFVBf2BQ24VhZz+7d6w43zNSvk7K9SERxOFbSyBVCICAMDRiZbimraMQJCBCvtfuxZi60twGzs10qW/jLlVdnL8x39pQbTP0ZykzT8CHJzG4y6BCFtVAXJyjIzSf6n8FJCL0XLvo2ENwKuOH1qZoAFyjrkWSYh025mXmts3Jvs/cz4NDUttYt5stC5CeUMw+urDEiG5YIEzU400548/MmDg=;25:s2D59E+fu0XTT2yyP/A77+RrjnQXscZm9TwbG5Rk7b0o+IZ62coT0HoPqkIJ5DVWiCTXNlr9IbGmJhZ1W+OSKqV9262NZgHgd+wLRHo7Dr3KhCVlBBpbaPb9IBXo1ua1WkFxAcCKvBL+wVPSz/gIdJ8CHTe9tGOdY0C+2wYgpSGJL0Z5fSwU2IY4THrc1St5KKmg1LDTSXDi6CvdVQRQVloFteFg7IklPGDUuPG9sDBx5umdy22xon37YjoIEuQpp+03ezRBFuEsC4xqNG6NdQ33aH/Eva2qZfubbKH+s7x3ic2s2ZJxkkNt694dFYkiP3Kmb8k3wgrc3Isq8FDMsg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0705; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0705;20:YlQJOz0l1M9tAGFk2oGClLSgkx42TxKqj+BCpEEZT57m4tp/UkT19Vpc2Ld3wu4zYk8DU8FIVvKeoeR71qmtezyDe+Qnex+OQeMBCbzdiGp8GO9BwEemn4GIXQ/OmXZhck4JhfyFLyqiW8rU+UJ4n+H2bcZjuXdC6jM1QtYzSn6dPFqV30DXYyWCzK55HpSE5bVJRi3vd1Ma6vWLs0EjiFWhldSMN/eIRTYwypPkd1IrdgoUScgRajAQtlGsXZt2kCUpjooMRhKkWPFAsZxRz4Ebm1WNJv9oMeiVFmyazAmCeFJzwASlIqvKwxqgy1LfOL9FGvTMFvxTc2Z0qGVXRvxI6R3PkatOJpI3jEUpcrDqO2ATlHnw5cDd+fTL+tsah7OOz1c0Ul2usz7Fkh7ZvUPGHWObzuZaGFiSkxWU1zhlCV/wG4rU3SPQhK9WrGPrNk7DcEEHIG2zcxoo6T216fV7krbNuG7zcMI+1A9KxuOUATCUAe5s53xS+le0IgE4 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(13017025)(13018025)(13023025)(8121501046)(13015025)(13024025)(3002001)(10201501046);SRVR:BLUPR12MB0705;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0705; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0705;4:EygQHH44LDNIk6xRD7fw5+ZMrdfUZntG/v4bpa8dcH7zhHKNZ6+FGfKd2VFlznEJcgXa1WrpcfKbNBj6xc0v4nqr2exca7nJwAeP99xX3+viDXBToNoVInigN2aDjYsXemRvt+qcP24z8muFfAVnVaH8wBXXXynk5mQZQuq7mXUFYK8IQx0P+WpNPNIUsRtkfrGATh9uCUWF1wM9dasKMk+ly1VBHJ5ur3NZJMgRfOtT3X6mN39eiRT0anMlYiupuQF3FvD5DZBs/h2ftvFiSSSwXaGvdtxuLdbRf+7RBoHbSFEYCsdxtgLZ3dp477tX/n9+6V5sT5OjQUexywdtmH23sjdVCwquHfnrJ+0a6/IriQQfCOpSP9xHN/dI5bx8YUrmjwZh7RcMqe27F+6OeSr51cK8zzWtO398A7BODcPgG/RGxsB9gv3KqUIKk3MgngDC18NRjVXEHh3AHS8a4A== X-Forefront-PRVS: 086943A159 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR12MB0705;23:pQyXXgSlAhedgG07W+q/dUqEOp2PNjd/h4DFPzXh0?= =?us-ascii?Q?4tVzap4WDFLtWsBpdkXaT5yuEoOWbWPZT44EiqRCM6y2COSI/jEZiBD5bvgR?= =?us-ascii?Q?O9Q4FoomFljR0UqeehbC8A1YC9AxgEDxxSCW5XGQNWbO4xuTbP06u3WfQKgX?= =?us-ascii?Q?7lFXftgOLvMk5TP6geK/CqY/1PProqFbHqTFA5fBCgK0dTZvIGdQFMqibpWI?= =?us-ascii?Q?coXR0wGu7LHJ1UgQQnKGRBHbOKYkZzPfqyMCyS0H0qPZ//FIjTSwtUVLRtGG?= =?us-ascii?Q?sQw4/VzJF0tXszea/NYtG+/k+NDu9dYQmaDfhCltH37UlHg/3URbZQUfznJ3?= =?us-ascii?Q?0QoieTgOUJ/ZkSNxhJrPhzm5SQIlsIP3eGSLIJRSvCFuW606ztWlWKz7KAWu?= =?us-ascii?Q?AE+iysO0I7AUTGjyRdZWYpR59jtsB/8tFbzuMJkrV/R0DxaM8XtxoI6MlAZ1?= =?us-ascii?Q?wRSufRMsBDfe0bSMacCerR9SthNN2kFkp1Br7gpi1j6bI+qKazaxBGxhsb0/?= =?us-ascii?Q?qdmkpY2lHro3HD59/apyiCy39Dl6nhJ71KXkktv4TkAgBr6pZlF35TC5/Ew5?= =?us-ascii?Q?s5gS2Frawcrvz0sCeHUy1i3oN+jwBnwRhnNH5u61wTR81SsiLKKhJqttkfk1?= =?us-ascii?Q?PE8ODBSV+RI7wlkTaoDgP2rApXWLTKuhw7TcA+KCNybgXxdtIvBBtLOSMxym?= =?us-ascii?Q?h9zVCB7m+e63+y8FgtIWSnbSeUjY9MFZt/MijHsmNU32jVgWUsTweoLeUUVU?= =?us-ascii?Q?AMdDD9FJ6FGwI62XihbXYZH6lBmbeatvbuJwsws3GvO4Irsb2wCZuFFrgHUr?= =?us-ascii?Q?6dCsfB6E6Oug6d/AfaHJSnBReTA5cn4ozOKKI4E9G8dkaMuat/pyDoAzKMHE?= =?us-ascii?Q?KQVqWK+mmsU7PGxmLwep9+4ZE8KF7nLRs93rNaTD2/w2heu9F9p9GKlGFis2?= =?us-ascii?Q?FYBsLXxQy3biRu1los9/ePAcpvN0xGfHGXHIYj5BPrsauc9Mrxqzl3TQLTWo?= =?us-ascii?Q?mk3Hhn1JBEyRzmyd4PwxqXBNUUJGdNXAuXB9CuDlboPVYMc7CORZgPtIxNHK?= =?us-ascii?Q?sifvQh6EZBYfkkiMrtawNC9VcONJEMfTJXz/CgjPrqXgkDV40P9IdA4aU105?= =?us-ascii?Q?FIgQ0D47r2LQVCIW4JdOpwAQ1clMX8LHzMrOD0zUvOe7bZ75+Wq5a6sXXONK?= =?us-ascii?Q?4NGB5VlkSiu/VYR0b0D6qc9ceUYLL483zfx?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0705;5:gnGH6CHDeXu/i43aHO0xfsEXOfsLt3mJxLq4FaxJE1euQZzYoUu/2Q1mz1+y1nBgwEXMA2PuSP7P7nbSa2Drb62bNldv+FjDrUPtPqVWYd1+PG1bnQA3Su8STdwfXhCPdA4LQWK6IhvbOcRZGC23YA==;24:of4Lf2pWwZPI+XW1GR076W8u0P7nH27M5V1TEdrxSPCgxBEiwKMyTQ9KOKUvx8J2KVnktn45fQ/9V3azUfC+n+0lJzsUfAQ0rti624kQZCg=;20:TY9PRV1XmaaLjBPCZ5gAoyWYeqHkb/CJdCGh0Cv5k86uMhvkL5GVtq4WFsMeL+tQLDKM0VrPro6fY7UC+6CKigYJ7iGBOt7d50z3eB2MQ6YF7yyj88IlImi4ZGLBj7EJJVqSnXSuJT9Qvv3NWwYGJoHnsinZCPi8zHD88XxUL+NqQBrJwmg4CcLCARvggOA+3uBZ3O+G+17rzwDKnRLImLACWHSsQTUr7n1exWMWfGyXO1y6SoCmx5eGeFQ585fL SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2016 02:27:50.5976 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0705 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 01, 2016 at 02:58:39PM +0100, Borislav Petkov wrote: > On Mon, Feb 29, 2016 at 12:30:47PM +0100, Thomas Gleixner wrote: > > On Tue, 1 Mar 2016, Huang Rui wrote: > > > On Fri, Feb 26, 2016 at 11:18:28AM +0100, Thomas Gleixner wrote: > > > > > +static int __init amd_power_pmu_init(void) > > > > > +{ > > > > > + int i, ret; > > > > > + u64 tmp; > > > > > + > > > > > + if (!x86_match_cpu(cpu_match)) > > > > > + return 0; > > > > > + > > > > > + if (!boot_cpu_has(X86_FEATURE_ACC_POWER)) > > > > > + return -ENODEV; > > > > > + > > > > > + cores_per_cu = amd_get_cores_per_cu(); > > > > > + cu_num = boot_cpu_data.x86_max_cores / cores_per_cu; > > > > > > > > Please use the new package management functions which are on the way to tip. > > > > > > > Can you give me some hints? > > > > http://git.kernel.org/tip/1f12e32f4cd5243ae46d8b933181be0d022c6793 > > > > topology_max_packages() is what you want. > > Rui, I think you want to use smp_num_siblings here. And we did define > that amd_get_cores_per_cu() but that's redundant: > > /* get compute unit information */ > smp_num_siblings = ((ebx >> 8) & 3) + 1; > c->compute_unit_id = ebx & 0xff; > cores_per_cu += ((ebx >> 8) & 3); > > So if I'm not missing anything else, we don't need that cores_per_cu > variable, nor do we need amd_get_cores_per_cu(). I'll zap this patch > from my queue. You can use smp_num_siblings in your patch instead which > is exported to everything. > That makes sense for me. Thanks, Boris, Thomas. We just want to know cores number per compute unit here. Thanks, Rui