From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754076AbcCBDNx (ORCPT ); Tue, 1 Mar 2016 22:13:53 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51102 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752787AbcCBDNu (ORCPT ); Tue, 1 Mar 2016 22:13:50 -0500 Date: Wed, 2 Mar 2016 12:13:38 +0900 From: Mark Brown To: Laxman Dewangan Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20160302031338.GU18327@sirena.org.uk> References: <1456835895-16503-1-git-send-email-ldewangan@nvidia.com> <1456835895-16503-3-git-send-email-ldewangan@nvidia.com> <20160302014421.GM18327@sirena.org.uk> <56D64984.8080405@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kJ9+PbHdtOUIdE1S" Content-Disposition: inline In-Reply-To: <56D64984.8080405@nvidia.com> X-Cookie: Adapt. Enjoy. Survive. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 122.212.32.58 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/4] regulator: core: Add support for active-discharge configuration X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kJ9+PbHdtOUIdE1S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 02, 2016 at 07:31:40AM +0530, Laxman Dewangan wrote: > Yaah, I agree. > I had other option to use 0 as default, 1 as disable and 2 as enable. but > generally for disable, we use 0 and for enable 1 and that's why I went to > -1,0,1 approach. > Will it be fine to have this as > 0: Default i..e do not change. > 1: disable. > 2: Enable. I'd suggest defining an enum here with default explicitly set to 0 but yes. --kJ9+PbHdtOUIdE1S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW1lphAAoJECTWi3JdVIfQswAIAIHJctOV0GylJiC5Nmq+/i6q YpOHi3S5nVl4OODk7x+n/dsSvU7kfCc0neobMezGyDuFyBUNw78yFHSDo/WXenhO lSzD9tY1NDDAL8CzfVLL6YmZFjqEzlFNfpN/w7GQf3uZsgYs09AEpQgT3zQvE0/E MpmMqv9XLJVZ3HQV+p6UJamuyRcGG/mNuJc3GucY9a6Y2SvwCm0SnuJPeXHDO3qs T8Kw9wB2/COFmaJ08n7PW21Hzn4gJJJ73MqPvKFWAYgcvjsRLl84mYZ9QhMsfdzT qnZreyPecyppnx0ME39U9xqYmVC74nwsfbl3rlZnx5gbHbvNInAsk8NUr5g6ueI= =BY0U -----END PGP SIGNATURE----- --kJ9+PbHdtOUIdE1S--