public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] net: jme: fix suspend/resume on JMC260
@ 2016-02-23 15:04 Diego Viola
  2016-02-23 16:34 ` Diego Viola
  2016-02-25  4:58 ` David Miller
  0 siblings, 2 replies; 12+ messages in thread
From: Diego Viola @ 2016-02-23 15:04 UTC (permalink / raw)
  To: cooldavid
  Cc: netdev, linux-kernel, richard.weinberger, pavel, rjw, davem,
	valdis.kletnieks, Diego Viola

The JMC260 network card fails to suspend/resume because the call to
jme_start_irq() was too early, moving the call to jme_start_irq() after
the call to jme_reset_link() makes it work.

Prior this change suspend/resume would fail unless /sys/power/pm_async=0
was explicitly specified.

Relevant bug report: https://bugzilla.kernel.org/show_bug.cgi?id=112351

Signed-off-by: Diego Viola <diego.viola@gmail.com>
---
 drivers/net/ethernet/jme.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index b1de7af..8adbe8f 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -3312,13 +3312,14 @@ jme_resume(struct device *dev)
 		jme_reset_phy_processor(jme);
 	jme_phy_calibration(jme);
 	jme_phy_setEA(jme);
-	jme_start_irq(jme);
 	netif_device_attach(netdev);
 
 	atomic_inc(&jme->link_changing);
 
 	jme_reset_link(jme);
 
+	jme_start_irq(jme);
+
 	return 0;
 }
 
-- 
2.7.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2016-03-05  2:26 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-23 15:04 [PATCH v3] net: jme: fix suspend/resume on JMC260 Diego Viola
2016-02-23 16:34 ` Diego Viola
2016-02-25  0:43   ` Diego Viola
2016-02-25  4:58 ` David Miller
2016-02-25 15:38   ` Diego Viola
2016-03-02  5:14   ` Guo-Fu Tseng
2016-03-03  3:19     ` Diego Viola
2016-03-03  5:55       ` Diego Viola
2016-03-03 21:14         ` Diego Viola
2016-03-03 21:19           ` Diego Viola
2016-03-04  4:32             ` Diego Viola
2016-03-05  2:26               ` Diego Viola

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox