From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754533AbcCBKK7 (ORCPT ); Wed, 2 Mar 2016 05:10:59 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:25711 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753337AbcCBKK5 (ORCPT ); Wed, 2 Mar 2016 05:10:57 -0500 Date: Wed, 2 Mar 2016 13:10:06 +0300 From: Dan Carpenter To: Joerg Roedel , Yong Wu Cc: Matthias Brugger , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch 1/2] iommu/mediatek: signedness bug in probe function Message-ID: <20160302101006.GF5533@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "larb_nr" needs to be signed for the error handling to work. "i" can be int as well. Fixes: 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver') Signed-off-by: Dan Carpenter diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 721ffdb..1a4022c 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -578,7 +578,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) struct resource *res; struct component_match *match = NULL; void *protect; - unsigned int i, larb_nr; + int i, larb_nr; int ret; data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);