From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754821AbcCBK0j (ORCPT ); Wed, 2 Mar 2016 05:26:39 -0500 Received: from down.free-electrons.com ([37.187.137.238]:39561 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753995AbcCBK0g (ORCPT ); Wed, 2 Mar 2016 05:26:36 -0500 Date: Wed, 2 Mar 2016 11:26:34 +0100 From: Alexandre Belloni To: Juergen Borleis Cc: kbuild test robot , rtc-linux@googlegroups.com, Alessandro Zummo , linux-kernel@vger.kernel.org Subject: Re: [abelloni:rtc-testing 55/55] drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063' Message-ID: <20160302102634.GN23985@piout.net> References: <201603020626.sgWd959D%fengguang.wu@intel.com> <201603021044.29444.jbe@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201603021044.29444.jbe@pengutronix.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 02/03/2016 at 10:44:29 +0100, Juergen Borleis wrote : > Hi Alexandre, > > On Tuesday 01 March 2016 23:17:45 kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git > > rtc-testing head: 58992ebde059d7faeab4c18bc17713c3b4c31208 > > commit: 58992ebde059d7faeab4c18bc17713c3b4c31208 [55/55] rtc: pcf85063: > > remove useless century handling config: x86_64-randconfig-x012-201609 > > (attached as .config) > > reproduce: > > git checkout 58992ebde059d7faeab4c18bc17713c3b4c31208 > > # save the attached .config to linux build tree > > make ARCH=x86_64 > > > > All warnings (new ones prefixed by >>): > > > > drivers/rtc/rtc-pcf85063.c: In function 'pcf85063_get_datetime': > > >> drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063' > > >> [-Wunused-variable] > > > > struct pcf85063 *pcf85063 = i2c_get_clientdata(client); > > ^ > > Due to your removement of the useless century handling the last user of 'struct > pcf85063' is gone. Seems we can remove this struct entirely. What do you > think? > Sure, that was also my reasoning when fixing that warning. I've sent follow up patches. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com