From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754686AbcCBJmf (ORCPT ); Wed, 2 Mar 2016 04:42:35 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:45348 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754284AbcCBJmc convert rfc822-to-8bit (ORCPT ); Wed, 2 Mar 2016 04:42:32 -0500 From: Juergen Borleis Organization: Pengutronix e.K. To: Alexandre Belloni Subject: Re: [abelloni:rtc-testing 55/55] drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063' Date: Wed, 2 Mar 2016 10:44:29 +0100 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: kbuild test robot , rtc-linux@googlegroups.com, Alessandro Zummo , linux-kernel@vger.kernel.org References: <201603020626.sgWd959D%fengguang.wu@intel.com> In-Reply-To: <201603020626.sgWd959D%fengguang.wu@intel.com> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <201603021044.29444.jbe@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: jbe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, On Tuesday 01 March 2016 23:17:45 kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git > rtc-testing head: 58992ebde059d7faeab4c18bc17713c3b4c31208 > commit: 58992ebde059d7faeab4c18bc17713c3b4c31208 [55/55] rtc: pcf85063: > remove useless century handling config: x86_64-randconfig-x012-201609 > (attached as .config) > reproduce: > git checkout 58992ebde059d7faeab4c18bc17713c3b4c31208 > # save the attached .config to linux build tree > make ARCH=x86_64 > > All warnings (new ones prefixed by >>): > > drivers/rtc/rtc-pcf85063.c: In function 'pcf85063_get_datetime': > >> drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063' > >> [-Wunused-variable] > > struct pcf85063 *pcf85063 = i2c_get_clientdata(client); > ^ Due to your removement of the useless century handling the last user of 'struct pcf85063' is gone. Seems we can remove this struct entirely. What do you think? Regards, Juergen -- Pengutronix e.K.                              | Juergen Borleis             | Industrial Linux Solutions                    | http://www.pengutronix.de/  |