From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Colin King <colin.king@canonical.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
Javi Merino <javi.merino@arm.com>, He Kuang <hekuang@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf script: fix double free on command_line
Date: Wed, 2 Mar 2016 09:13:02 -0300 [thread overview]
Message-ID: <20160302121302.GH3604@kernel.org> (raw)
In-Reply-To: <20160302073143.GB7272@krava>
Em Wed, Mar 02, 2016 at 08:31:43AM +0100, Jiri Olsa escreveu:
> On Tue, Mar 01, 2016 at 11:46:20PM +0000, Colin King wrote:
> > command_line is free'd twice if db_export__branch_types fails. To
> > avoid this, defer the free'ing of command_line to after this call
> > so that the error return path will just free command_line once.
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks, applied.
- Arnaldo
next prev parent reply other threads:[~2016-03-02 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 23:46 [PATCH] perf script: fix double free on command_line Colin King
2016-03-02 7:31 ` Jiri Olsa
2016-03-02 12:13 ` Arnaldo Carvalho de Melo [this message]
2016-03-05 8:18 ` [tip:perf/core] perf script: Fix " tip-bot for Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302121302.GH3604@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=colin.king@canonical.com \
--cc=hekuang@huawei.com \
--cc=javi.merino@arm.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox