From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755305AbcCBMNJ (ORCPT ); Wed, 2 Mar 2016 07:13:09 -0500 Received: from mail.kernel.org ([198.145.29.136]:44611 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755214AbcCBMNH (ORCPT ); Wed, 2 Mar 2016 07:13:07 -0500 Date: Wed, 2 Mar 2016 09:13:02 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Colin King , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Jiri Olsa , Adrian Hunter , Steven Rostedt , Javi Merino , He Kuang , linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf script: fix double free on command_line Message-ID: <20160302121302.GH3604@kernel.org> References: <1456875980-25606-1-git-send-email-colin.king@canonical.com> <20160302073143.GB7272@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160302073143.GB7272@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Mar 02, 2016 at 08:31:43AM +0100, Jiri Olsa escreveu: > On Tue, Mar 01, 2016 at 11:46:20PM +0000, Colin King wrote: > > command_line is free'd twice if db_export__branch_types fails. To > > avoid this, defer the free'ing of command_line to after this call > > so that the error return path will just free command_line once. > Acked-by: Jiri Olsa Thanks, applied. - Arnaldo