From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755290AbcCBNDY (ORCPT ); Wed, 2 Mar 2016 08:03:24 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:38028 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755056AbcCBNDV (ORCPT ); Wed, 2 Mar 2016 08:03:21 -0500 Date: Wed, 2 Mar 2016 13:03:16 +0000 From: Lee Jones To: Heikki Krogerus Cc: "Rafael J. Wysocki" , Mika Westerberg , Andy Shevchenko , Thierry Reding , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH] device property: don't bother the drivers with struct property_set Message-ID: <20160302130316.GA3444@x1> References: <1456485600-129229-1-git-send-email-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1456485600-129229-1-git-send-email-heikki.krogerus@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Feb 2016, Heikki Krogerus wrote: > Since device_add_property_set() now always takes a copy of > the property_set, and also since the fwnode type is always > hard coded to be FWNODE_PDATA, there is no need for the > drivers to deliver the entire struct property_set. The > function can just create the instance of it on its own and > bind the properties from the drivers to it on the spot. > > This renames device_add_property_set() to > device_add_properties(). The function now takes struct > property_entry as its parameter instead of struct > property_set. > > Signed-off-by: Heikki Krogerus > --- > arch/arm/mach-tegra/board-paz00.c | 6 +----- > drivers/base/platform.c | 19 ++++++++++--------- > drivers/base/property.c | 35 ++++++++++++++++++++++------------- > drivers/mfd/intel-lpss-acpi.c | 6 +----- > drivers/mfd/intel-lpss-pci.c | 14 +++----------- > drivers/mfd/intel-lpss.c | 2 +- > drivers/mfd/intel-lpss.h | 2 +- > drivers/mfd/mfd-core.c | 4 ++-- Acked-by: Lee Jones > include/linux/mfd/core.h | 2 +- > include/linux/platform_device.h | 4 ++-- > include/linux/property.h | 15 +++------------ > 11 files changed, 47 insertions(+), 62 deletions(-) > > Hi Rafael, > > This depends on Johannes' wireless next tree: > git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog