linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: "Terje Bergström" <tbergstrom@nvidia.com>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	gnurou@gmail.com
Subject: Re: [PATCH v4 1/2] gpu: host1x: Set DMA mask
Date: Wed, 2 Mar 2016 18:08:23 +0100	[thread overview]
Message-ID: <20160302170823.GA486@ulmo.nvidia.com> (raw)
In-Reply-To: <1456477613-24995-1-git-send-email-acourbot@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

On Fri, Feb 26, 2016 at 06:06:52PM +0900, Alexandre Courbot wrote:
> The default DMA mask covers a 32 bits address range, but host1x devices
> can address a larger range on TK1 and TX1. Set the DMA mask to the range
> addressable when we use the IOMMU to prevent the use of bounce buffers.
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> Change since v3:
> - Use the IOMMU-addressable range (when IOMMU is available) for each host1x
>   variation. This ensures that we can cover all physical memory while remaining
>   conservative if IOMMU is not used.
> - Set the DMA range on the host1x device itself so all its childs inherit from it
> 
>  drivers/gpu/host1x/dev.c | 7 +++++++
>  drivers/gpu/host1x/dev.h | 1 +
>  2 files changed, 8 insertions(+)

I think this could still be better, but what I have in mind is much more
involved and this does fix the issue with a minimum amount of code, so I
have applied this for now.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      parent reply	other threads:[~2016-03-02 17:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26  9:06 [PATCH v4 1/2] gpu: host1x: Set DMA mask Alexandre Courbot
2016-02-26  9:06 ` [PATCH v4 2/2] gpu: host1x: Set DMA ops on device creation Alexandre Courbot
2016-03-02 17:08   ` Thierry Reding
2016-03-02 17:08 ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302170823.GA486@ulmo.nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=acourbot@nvidia.com \
    --cc=gnurou@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=tbergstrom@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).