From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754270AbcCBXgM (ORCPT ); Wed, 2 Mar 2016 18:36:12 -0500 Received: from down.free-electrons.com ([37.187.137.238]:60514 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753016AbcCBXgL (ORCPT ); Wed, 2 Mar 2016 18:36:11 -0500 Date: Thu, 3 Mar 2016 00:36:09 +0100 From: Alexandre Belloni To: Dan Carpenter Cc: Joshua Kinard , Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] rtc: ds1685: passing bogus values to irq_restore Message-ID: <20160302233609.GC2567@piout.net> References: <20160302100745.GB5533@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160302100745.GB5533@mwanda> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/2016 at 13:07:45 +0300, Dan Carpenter wrote : > We call spin_lock_irqrestore with "flags" set to zero instead of to the > value from spin_lock_irqsave(). > > Fixes: aaaf5fbf56f1 ('rtc: add driver for DS1685 family of real time clocks') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com