From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755323AbcCCDtR (ORCPT ); Wed, 2 Mar 2016 22:49:17 -0500 Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:51898 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752861AbcCCDtP (ORCPT ); Wed, 2 Mar 2016 22:49:15 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BWCAB3s9dWOVEqLHleKAECgw+BP4Jtg3mfaQaLd4VIhAiGCQICAQECgUBNAQEBAQEBBwEBAQFAAUCEQgEBBDocIxAIAxgJJQ8FJQMHGhOIILwuAQseGIUyhQKIbwEElxeNWYFVFYREiFJEjgiCZRmBXCguAYhfAQEB Date: Thu, 3 Mar 2016 14:49:11 +1100 From: Dave Chinner To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, Andrew Morton , Dan Williams , Matthew Wilcox , linux-nvdimm@ml01.01.org Subject: Re: [PATCH v2] dax: check return value of dax_radix_entry() Message-ID: <20160303034911.GP30721@dastard> References: <1456938051-14847-1-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456938051-14847-1-git-send-email-ross.zwisler@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2016 at 10:00:51AM -0700, Ross Zwisler wrote: > dax_pfn_mkwrite() previously wasn't checking the return value of the call > to dax_radix_entry(), which was a mistake. > > Instead, capture this return value and return the appropriate VM_FAULT_ > value. > > Signed-off-by: Ross Zwisler Hi Ross, Can you please cc dax stuff to linux-fsdevel? it is way too easy to miss stuff like this when lkml is the only list it's sent to? That said, the change looks good. Cheers, Dave. -- Dave Chinner david@fromorbit.com