From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>,
mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
sergey.senozhatsky@gmail.com, sergey.senozhatsky.work@gmail.com
Subject: Re: + mm-zsmalloc-add-freeable-column-to-pool-stat.patch added to -mm tree
Date: Thu, 3 Mar 2016 17:36:54 +0900 [thread overview]
Message-ID: <20160303083654.GA31159@swordfish> (raw)
In-Reply-To: <56d4d058.oW1ncOPbIYcKSMjB%akpm@linux-foundation.org>
On (02/29/16 15:12), akpm@linux-foundation.org wrote:
[..]
> seq_puts(s, "\n");
> - seq_printf(s, " %5s %5s %11lu %12lu %13lu %10lu %10lu\n",
> + seq_printf(s, " %5s %5s %11lu %12lu %13lu %10lu %10lu %16s %7lu\n",
> "Total", "", total_class_almost_full,
> total_class_almost_empty, total_objs,
> - total_used_objs, total_pages);
> + total_used_objs, total_pages, "", total_freeable);
Andrew, may I please ask you to add the following small -fix patch?
looks like I failed to squash patches on my side properly and
`total_freeable' is not exactly aligned with the `freeable'
column name (off by one char %7 -> %8).
---
mm/zsmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 1023e0d..d43f68e 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -556,7 +556,7 @@ static int zs_stats_size_show(struct seq_file *s, void *v)
}
seq_puts(s, "\n");
- seq_printf(s, " %5s %5s %11lu %12lu %13lu %10lu %10lu %16s %7lu\n",
+ seq_printf(s, " %5s %5s %11lu %12lu %13lu %10lu %10lu %16s %8lu\n",
"Total", "", total_class_almost_full,
total_class_almost_empty, total_objs,
total_used_objs, total_pages, "", total_freeable);
parent reply other threads:[~2016-03-03 8:35 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <56d4d058.oW1ncOPbIYcKSMjB%akpm@linux-foundation.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303083654.GA31159@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox