From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757122AbcCCIfh (ORCPT ); Thu, 3 Mar 2016 03:35:37 -0500 Received: from mail-pf0-f169.google.com ([209.85.192.169]:36442 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755349AbcCCIff (ORCPT ); Thu, 3 Mar 2016 03:35:35 -0500 Date: Thu, 3 Mar 2016 17:36:54 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Minchan Kim , mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org, sergey.senozhatsky@gmail.com, sergey.senozhatsky.work@gmail.com Subject: Re: + mm-zsmalloc-add-freeable-column-to-pool-stat.patch added to -mm tree Message-ID: <20160303083654.GA31159@swordfish> References: <56d4d058.oW1ncOPbIYcKSMjB%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56d4d058.oW1ncOPbIYcKSMjB%akpm@linux-foundation.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (02/29/16 15:12), akpm@linux-foundation.org wrote: [..] > seq_puts(s, "\n"); > - seq_printf(s, " %5s %5s %11lu %12lu %13lu %10lu %10lu\n", > + seq_printf(s, " %5s %5s %11lu %12lu %13lu %10lu %10lu %16s %7lu\n", > "Total", "", total_class_almost_full, > total_class_almost_empty, total_objs, > - total_used_objs, total_pages); > + total_used_objs, total_pages, "", total_freeable); Andrew, may I please ask you to add the following small -fix patch? looks like I failed to squash patches on my side properly and `total_freeable' is not exactly aligned with the `freeable' column name (off by one char %7 -> %8). --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 1023e0d..d43f68e 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -556,7 +556,7 @@ static int zs_stats_size_show(struct seq_file *s, void *v) } seq_puts(s, "\n"); - seq_printf(s, " %5s %5s %11lu %12lu %13lu %10lu %10lu %16s %7lu\n", + seq_printf(s, " %5s %5s %11lu %12lu %13lu %10lu %10lu %16s %8lu\n", "Total", "", total_class_almost_full, total_class_almost_empty, total_objs, total_used_objs, total_pages, "", total_freeable);