Re: [PATCH v2 1/10] cpufreq: Reduce cpufreq_update_util() overhead a bit

Peter Zijlstra
2016-03-09T15:29:51Z

On Wed, Mar 09, 2016 at 03:17:48PM +0100, Rafael J. Wysocki wrote:
> > That said, how about the below? It avoids a function call.
>
> That is fine by me.
>
> What about taking it a bit further, though, and moving the definition
> of cpufreq_update_util_data to somewhere under kernel/sched/ (like
> kernel/sched/cpufreq.c maybe)?
>
> Then, the whole static inline void cpufreq_update_util() definition
> can go into kernel/sched/sched.h (it doesn't have to be visible
> anywhere beyond kernel/sched/) and the only thing that needs to be
> exported to cpufreq will be a helper (or two), to set/clear the
> cpufreq_update_util_data pointers.
>
> I'll try to cut a patch doing that later today for illustration.

Right, that's a blend with your second patch. Sure.