Re: [PATCH 3/6] cpufreq: governor: New data type for management part of dbs_data

Viresh Kumar
2016-03-03T05:54:20Z

On 02-03-16, 03:08, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> In addition to fields representing governor tunables, struct dbs_data
> contains some fields needed for the management of objects of that
> type. As it turns out, that part of struct dbs_data may be shared
> with (future) governors that won't use the common code used by
> "ondemand" and "conservative", so move it to a separate struct type
> and modify the code using struct dbs_data to follow.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/cpufreq/cpufreq_conservative.c | 15 +++--
> drivers/cpufreq/cpufreq_governor.c | 90 ++++++++++++++++++++-------------
> drivers/cpufreq/cpufreq_governor.h | 36 +++++++------
> drivers/cpufreq/cpufreq_ondemand.c | 19 ++++--
> 4 files changed, 97 insertions(+), 63 deletions(-)
>
> Index: linux-pm/drivers/cpufreq/cpufreq_governor.h
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq_governor.h
> +++ linux-pm/drivers/cpufreq/cpufreq_governor.h
> @@ -41,6 +41,13 @@
> /* Ondemand Sampling types */
> enum {OD_NORMAL_SAMPLE, OD_SUB_SAMPLE};
>
> +struct gov_tunables {
> + struct kobject kobj;
> + struct list_head policy_list;
> + struct mutex update_lock;
> + int usage_count;
> +};

Everything else looks fine, but I don't think that you have named it
properly. Every thing else present in struct dbs_data are tunables,
but not this. And so gov_tunables doesn't suit at all here..

--
viresh