From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 05/11] perf stat: Check existence of frontend/backed stalled cycles
Date: Thu, 3 Mar 2016 09:50:27 -0300 [thread overview]
Message-ID: <20160303125027.GC2528@redhat.com> (raw)
In-Reply-To: <20160303124900.GB2528@redhat.com>
Em Thu, Mar 03, 2016 at 09:49:00AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Mar 03, 2016 at 09:28:18AM +0100, Ingo Molnar escreveu:
> >
> > * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> > > Before:
> > >
> > > $ perf stat ls
> > > a.patch
> > >
> > > Performance counter stats for 'ls':
> > >
> > > 0.822067 task-clock (msec) # 0.873 CPUs utilized (82.26%)
> > > 0 context-switches # 0.000 K/sec (82.26%)
> > > 0 cpu-migrations # 0.000 K/sec (82.26%)
> > > 125 page-faults # 0.152 M/sec (82.26%)
> > > 2,516,127 cycles # 3.061 GHz (82.84%)
> > > <not supported> stalled-cycles-frontend
> > > <not supported> stalled-cycles-backend
> > > 2,430,467 instructions # 0.97 insn per cycle (82.84%)
> > > 486,235 branches # 591.479 M/sec (82.84%)
> > > 18,389 branch-misses # 3.78% of all branches (82.84%)
> > >
> > > 0.000941536 seconds time elapsed
> > > $
> > >
> > > After:
> > >
> > > $ perf stat ls
> > > a.patch
> > >
> > > Performance counter stats for 'ls':
> > >
> > > 0.824919 task-clock (msec) # 0.893 CPUs utilized (85.47%)
> > > 0 context-switches # 0.000 K/sec (85.47%)
> > > 0 cpu-migrations # 0.000 K/sec (85.47%)
> > > 124 page-faults # 0.150 M/sec (85.47%)
> > > 2521790 cycles # 3.057 GHz (86.15%)
> > > 2364913 instructions # 0.94 insn per cycle (86.15%)
> > > 471970 branches # 572.141 M/sec (86.15%)
> > > 16935 branch-misses # 3.59% of all branches (86.15%)
> > >
> > > 0.000923397 seconds time elapsed
> > > $
> >
> > Btw., the output format regression is visible in this changelog already...
>
> Right, uf, should've pick this up at this point :-\
>
> Will go back and fix it up, so that we don't introduce a regression.
Well, in this case its not a matter of fixing the patch, but making sure
that Jiri's locale pmu parsing fix comes before this patch, so inserting
a patch, will do.
- Arnaldo
next prev parent reply other threads:[~2016-03-03 12:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 19:21 [GIT PULL 00/11] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-02-29 19:21 ` [PATCH 01/11] perf tools: Fix python extension build Arnaldo Carvalho de Melo
2016-02-29 19:21 ` [PATCH 02/11] perf trace: Check and discard not only 'nr' but also '__syscall_nr' Arnaldo Carvalho de Melo
2016-02-29 19:21 ` [PATCH 03/11] tracing/syscalls: Rename "/format" tracepoint field name "nr" to "__syscall_nr: Arnaldo Carvalho de Melo
2016-02-29 19:22 ` [PATCH 04/11] tools lib traceevent: Split pevent_print_event() into specific functionality functions Arnaldo Carvalho de Melo
2016-02-29 19:22 ` [PATCH 05/11] perf stat: Check existence of frontend/backed stalled cycles Arnaldo Carvalho de Melo
2016-03-03 8:28 ` Ingo Molnar
2016-03-03 12:49 ` Arnaldo Carvalho de Melo
2016-03-03 12:50 ` Arnaldo Carvalho de Melo [this message]
2016-02-29 19:22 ` [PATCH 06/11] perf data: Support converting data from bpf_perf_event_output() Arnaldo Carvalho de Melo
2016-02-29 19:22 ` [PATCH 07/11] perf data: Explicitly set byte order for integer types Arnaldo Carvalho de Melo
2016-02-29 19:22 ` [PATCH 08/11] perf record: Use WARN_ONCE to replace 'if' condition Arnaldo Carvalho de Melo
2016-02-29 19:22 ` [PATCH 09/11] perf record: Extract synthesize code to record__synthesize() Arnaldo Carvalho de Melo
2016-02-29 19:22 ` [PATCH 10/11] perf record: Introduce record__finish_output() to finish a perf.data Arnaldo Carvalho de Melo
2016-02-29 19:22 ` [PATCH 11/11] perf record: Ensure return non-zero rc when mmap fail Arnaldo Carvalho de Melo
2016-03-03 8:21 ` [GIT PULL 00/11] perf/core improvements and fixes Ingo Molnar
2016-03-03 9:15 ` Jiri Olsa
2016-03-03 9:53 ` [PATCH] perf tools: Fix locale handling in pmu parsing Jiri Olsa
2016-03-03 16:20 ` Andi Kleen
2016-03-05 8:14 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-03-08 13:23 ` Ingo Molnar
2016-03-08 18:42 ` [PATCH][perf/core] perf tools: Omit unnecessary cast in perf_pmu__parse_scale Jiri Olsa
2016-03-09 13:43 ` Arnaldo Carvalho de Melo
2016-03-11 8:46 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-03-03 14:38 ` [GIT PULL 00/11] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-03-05 8:08 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303125027.GC2528@redhat.com \
--to=acme@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).