From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757733AbcCCOZk (ORCPT ); Thu, 3 Mar 2016 09:25:40 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:48692 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932363AbcCCOZF (ORCPT ); Thu, 3 Mar 2016 09:25:05 -0500 Date: Thu, 3 Mar 2016 15:25:01 +0100 From: Andrew Lunn To: Colin King Cc: Florian Fainelli , "David S . Miller" , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] asix: do not free array priv->mdio->irq Message-ID: <20160303142501.GF15541@lunn.ch> References: <1457011676-19042-1-git-send-email-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457011676-19042-1-git-send-email-colin.king@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2016 at 01:27:56PM +0000, Colin King wrote: > From: Colin Ian King > > Used to be allocated and required freeing, but now > priv->mdio->irq is now a fixed sized array and should no longer be > free'd. > > Issue detected using static analysis with CoverityScan > > Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core") > Signed-off-by: Colin Ian King Reviewed-by: Andrew Lunn Thanks Andrew > --- > drivers/net/usb/ax88172a.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/usb/ax88172a.c b/drivers/net/usb/ax88172a.c > index 224e7d8..cf77f2d 100644 > --- a/drivers/net/usb/ax88172a.c > +++ b/drivers/net/usb/ax88172a.c > @@ -134,7 +134,6 @@ static void ax88172a_remove_mdio(struct usbnet *dev) > > netdev_info(dev->net, "deregistering mdio bus %s\n", priv->mdio->id); > mdiobus_unregister(priv->mdio); > - kfree(priv->mdio->irq); > mdiobus_free(priv->mdio); > } > > -- > 2.7.0 >