* [PATCH] asix: do not free array priv->mdio->irq
@ 2016-03-03 13:27 Colin King
2016-03-03 14:25 ` Andrew Lunn
2016-03-07 3:58 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2016-03-03 13:27 UTC (permalink / raw)
To: Florian Fainelli, Andrew Lunn, David S . Miller, linux-usb,
netdev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Used to be allocated and required freeing, but now
priv->mdio->irq is now a fixed sized array and should no longer be
free'd.
Issue detected using static analysis with CoverityScan
Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/usb/ax88172a.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/ax88172a.c b/drivers/net/usb/ax88172a.c
index 224e7d8..cf77f2d 100644
--- a/drivers/net/usb/ax88172a.c
+++ b/drivers/net/usb/ax88172a.c
@@ -134,7 +134,6 @@ static void ax88172a_remove_mdio(struct usbnet *dev)
netdev_info(dev->net, "deregistering mdio bus %s\n", priv->mdio->id);
mdiobus_unregister(priv->mdio);
- kfree(priv->mdio->irq);
mdiobus_free(priv->mdio);
}
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] asix: do not free array priv->mdio->irq
2016-03-03 13:27 [PATCH] asix: do not free array priv->mdio->irq Colin King
@ 2016-03-03 14:25 ` Andrew Lunn
2016-03-07 3:58 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2016-03-03 14:25 UTC (permalink / raw)
To: Colin King
Cc: Florian Fainelli, David S . Miller, linux-usb, netdev,
linux-kernel
On Thu, Mar 03, 2016 at 01:27:56PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Used to be allocated and required freeing, but now
> priv->mdio->irq is now a fixed sized array and should no longer be
> free'd.
>
> Issue detected using static analysis with CoverityScan
>
> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
> ---
> drivers/net/usb/ax88172a.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/usb/ax88172a.c b/drivers/net/usb/ax88172a.c
> index 224e7d8..cf77f2d 100644
> --- a/drivers/net/usb/ax88172a.c
> +++ b/drivers/net/usb/ax88172a.c
> @@ -134,7 +134,6 @@ static void ax88172a_remove_mdio(struct usbnet *dev)
>
> netdev_info(dev->net, "deregistering mdio bus %s\n", priv->mdio->id);
> mdiobus_unregister(priv->mdio);
> - kfree(priv->mdio->irq);
> mdiobus_free(priv->mdio);
> }
>
> --
> 2.7.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] asix: do not free array priv->mdio->irq
2016-03-03 13:27 [PATCH] asix: do not free array priv->mdio->irq Colin King
2016-03-03 14:25 ` Andrew Lunn
@ 2016-03-07 3:58 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-03-07 3:58 UTC (permalink / raw)
To: colin.king; +Cc: f.fainelli, andrew, linux-usb, netdev, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 3 Mar 2016 13:27:56 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Used to be allocated and required freeing, but now
> priv->mdio->irq is now a fixed sized array and should no longer be
> free'd.
>
> Issue detected using static analysis with CoverityScan
>
> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-07 3:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-03 13:27 [PATCH] asix: do not free array priv->mdio->irq Colin King
2016-03-03 14:25 ` Andrew Lunn
2016-03-07 3:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox