From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758047AbcCCPQh (ORCPT ); Thu, 3 Mar 2016 10:16:37 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:48791 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756498AbcCCPQf (ORCPT ); Thu, 3 Mar 2016 10:16:35 -0500 Date: Thu, 3 Mar 2016 16:16:31 +0100 From: Andrew Lunn To: Colin King Cc: Vince Bridgers , netdev@vger.kernel.org, nios2-dev@lists.rocketboards.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: eth: altera: do not free array priv->mdio->irq Message-ID: <20160303151631.GL15541@lunn.ch> References: <1457012838-19743-1-git-send-email-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457012838-19743-1-git-send-email-colin.king@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2016 at 01:47:18PM +0000, Colin King wrote: > From: Colin Ian King > > priv->mdio->irq used to be allocated and required freeing, but it > is now a fixed sized array and should no longer be free'd. > > Issue detected using static analysis with CoverityScan > > Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core") > Signed-off-by: Colin Ian King Reviewed-by: Andrew Lunn Thanks Andrew > --- > drivers/net/ethernet/altera/altera_tse_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c > index 1747285..f749e4d 100644 > --- a/drivers/net/ethernet/altera/altera_tse_main.c > +++ b/drivers/net/ethernet/altera/altera_tse_main.c > @@ -193,7 +193,6 @@ static void altera_tse_mdio_destroy(struct net_device *dev) > priv->mdio->id); > > mdiobus_unregister(priv->mdio); > - kfree(priv->mdio->irq); > mdiobus_free(priv->mdio); > priv->mdio = NULL; > } > -- > 2.7.0 >