From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758102AbcCCPjF (ORCPT ); Thu, 3 Mar 2016 10:39:05 -0500 Received: from mga14.intel.com ([192.55.52.115]:48129 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbcCCPjD (ORCPT ); Thu, 3 Mar 2016 10:39:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,532,1449561600"; d="scan'208";a="926106550" Date: Thu, 3 Mar 2016 08:38:42 -0700 From: Ross Zwisler To: Dave Chinner Cc: Ross Zwisler , linux-kernel@vger.kernel.org, Andrew Morton , Dan Williams , Matthew Wilcox , linux-nvdimm@ml01.01.org Subject: Re: [PATCH v2] dax: check return value of dax_radix_entry() Message-ID: <20160303153842.GB23797@linux.intel.com> References: <1456938051-14847-1-git-send-email-ross.zwisler@linux.intel.com> <20160303034911.GP30721@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160303034911.GP30721@dastard> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2016 at 02:49:11PM +1100, Dave Chinner wrote: > On Wed, Mar 02, 2016 at 10:00:51AM -0700, Ross Zwisler wrote: > > dax_pfn_mkwrite() previously wasn't checking the return value of the call > > to dax_radix_entry(), which was a mistake. > > > > Instead, capture this return value and return the appropriate VM_FAULT_ > > value. > > > > Signed-off-by: Ross Zwisler > > Hi Ross, > > Can you please cc dax stuff to linux-fsdevel? it is way too easy to > miss stuff like this when lkml is the only list it's sent to? Sure, will do.