From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932481AbcCCPjn (ORCPT ); Thu, 3 Mar 2016 10:39:43 -0500 Received: from mga02.intel.com ([134.134.136.20]:22697 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758133AbcCCPjl (ORCPT ); Thu, 3 Mar 2016 10:39:41 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,532,1449561600"; d="scan'208";a="900443408" Date: Thu, 3 Mar 2016 21:13:46 +0530 From: Vinod Koul To: Dan Carpenter Cc: Sudeep Dutt , Ashutosh Dixit , Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] dma/mic_x100_dma: IS_ERR() vs PTR_ERR() typo Message-ID: <20160303154346.GP11154@localhost> References: <20160229095107.GA32061@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160229095107.GA32061@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 29, 2016 at 12:51:07PM +0300, Dan Carpenter wrote: > This is harmless because the caller only cares about zero vs non-zero > but we should be returning PTR_ERR() here. Applied thanks -- ~Vinod