From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751312AbcCCT7g (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 Mar 2016 14:59:36 -0500
Received: from mail.kernel.org ([198.145.29.136]:60540 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750751AbcCCT7f (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 Mar 2016 14:59:35 -0500
Date: Thu, 3 Mar 2016 16:59:29 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Colin King <colin.king@canonical.com>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, Wang Nan <wangnan0@huawei.com>,
        He Kuang <hekuang@huawei.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: explicitly declare inc_group_count as a void
 function
Message-ID: <20160303195929.GW3604@kernel.org>
References: <1457008214-14393-1-git-send-email-colin.king@canonical.com>
 <20160303123939.GA1466@krava.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160303123939.GA1466@krava.redhat.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Mar 03, 2016 at 01:39:39PM +0100, Jiri Olsa escreveu:
> On Thu, Mar 03, 2016 at 12:30:14PM +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > The return type is not defined, so it defaults to int, however,
> > the function is not returning anything, so this is clearly not
> > correct. Make it a void function.
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks, applied.